sedona icon indicating copy to clipboard operation
sedona copied to clipboard

[SEDONA-738] Add moran i autocorrelation.

Open Imbruced opened this issue 7 months ago • 5 comments

Did you read the Contributor Guide?

  • Yes

Is this PR related to a ticket?

SEDONA-738

What changes were proposed in this PR?

MoranI index

How was this patch tested?

Unit tests

Did this PR include necessary documentation updates?

Yes

Imbruced avatar Jun 04 '25 21:06 Imbruced

I need to add docs

Imbruced avatar Jun 04 '25 21:06 Imbruced

and update the description of the MR

Imbruced avatar Jun 04 '25 21:06 Imbruced

Thanks for this Pawel.

I think we need an ST Function for this. Currently it is asymmetric with the other stats functions in this regard.

I also believe that we should deprecate these function call interfaces for geostats functions and tell users to use the ST functions instead. If we go this direction I would advise against making python and public scala functions for morans I (other than ST functions for the df interfaces of course)

james-willis avatar Jun 06 '25 20:06 james-willis

@james-willis Is your SQL function framework able to support Pawel's Moran'I case as well? Maybe you can point him to the right place for this?

jiayuasu avatar Jun 07 '25 23:06 jiayuasu

Sure. We should be able to wrap the function in this PR with an implementation of a PhysicalFunction.

Here are the existing ones.

Here is the PR that added SQL support to geostats

james-willis avatar Jun 10 '25 17:06 james-willis

@Imbruced I will merge this for now but the doc needs significant improvement. I believe we need some comprehensive end-to-end examples of each Stat function

jiayuasu avatar Jul 17 '25 17:07 jiayuasu

Filed a ticket for ST function: https://github.com/apache/sedona/issues/2115

james-willis avatar Jul 17 '25 21:07 james-willis