sedona icon indicating copy to clipboard operation
sedona copied to clipboard

Add AUTHORS & Script auto AUTHORS generate_authors

Open BDadmehr0 opened this issue 9 months ago • 7 comments

@jbampton

AUTHORS file look like mruby/AUTHORS

BDadmehr0 avatar Mar 29 '25 13:03 BDadmehr0

fixed @jbampton

BDadmehr0 avatar Mar 30 '25 06:03 BDadmehr0

It seems the commit totals are not 100% correct.

@AmirTallap would you like to review this PR ?

Is there an easier way to do this ?

jbampton avatar Mar 30 '25 07:03 jbampton

It seems the commit totals are not 100% correct.

@AmirTallap would you like to review this PR ?

Is there an easier way to do this ?

Checking!

AmirTallap avatar Mar 30 '25 07:03 AmirTallap

I fixed all the Bandit errors that were resolvable, but Bandit raises default security warnings for subprocess (B603 and B404), which don't have alternative solutions, so we need to silence them. @jbampton

https://github.com/apache/sedona/pull/1895/commits/b3d9a634ee8f4e1164dff25eaa4f51ba4896773d

Bandit output

[main]  INFO    profile include tests: None
[main]  INFO    profile exclude tests: None
[main]  INFO    cli include tests: None    
[main]  INFO    cli exclude tests: None    
[main]  INFO    running on Python 3.13.2   
Run started:2025-03-30 08:22:17.869637 

Test results:
        No issues identified.

Code scanned:
        Total lines of code: 71        
        Total lines skipped (#nosec): 1

Run metrics:
        Total issues (by severity):    
                Undefined: 0
                Low: 0
                Medium: 0
                High: 0
        Total issues (by confidence):  
                Undefined: 0
                Low: 0
                Medium: 0
                High: 0
Files skipped (0):

BDadmehr0 avatar Mar 30 '25 08:03 BDadmehr0

Hey @BDadmehr0 thanks for all of this.

Pretty sure the commit totals are not correct for some contributors

jbampton avatar Apr 11 '25 03:04 jbampton

Hey @BDadmehr0 thanks for all of this.

Pretty sure the commit totals are not correct for some contributors

Hello, sorry for the delay.

I've improved my script, but I need to make sure the current script isn't working correctly. If you're referring to the file https://github.com/apache/sedona/pull/1895/files#diff-ab6af77435f58cc0c9d4c31dfe05656e45187cc7c7fc02aada401a7642125463, I should mention that this script needs to be run in a cloned environment of https://github.com/apache/sedona/ on the main branch that has been recently updated to correctly show the commits.

Please test this and let me know.

BDadmehr0 avatar Apr 14 '25 21:04 BDadmehr0

Why do I want this? Because my improved script also doesn't fetch the latest commits in my cloned branch. @jbampton

> python tools/scripts/generate_authors.py                                                                                      ~/Github/sedona(AUTHORS✗)@archlinux
AUTHORS file generated successfully.

Top contributors:
 1.   424 Jia Yu @jiayu
 2.   368 Jia Yu 
 3.   167 John Bampton @jbampton
 4.    78 Kristin Cowalcijk 
 5.    57 Nilesh Gajwani 
 6.    56 Furqaan Khan @46216254/furqaankhan
 7.    37 jinxuan wu 
 8.    36 Furqaanahmed Khan @46216254/furqaankhan
 9.    35 zongsizhang 
10.    34 Kristin Cowalcijk @kontinuation

BDadmehr0 avatar Apr 14 '25 21:04 BDadmehr0