sedona icon indicating copy to clipboard operation
sedona copied to clipboard

[SEDONA-527] Add `pre-commit` hook `check-json`; Lint JSON files

Open jbampton opened this issue 1 year ago • 0 comments

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-527. The PR name follows the format [SEDONA-XXX] my subject.

What changes were proposed in this PR?

Added another hook to our pre-commit framework:

https://github.com/pre-commit/pre-commit-hooks?tab=readme-ov-file#check-json

How was this patch tested?

With the new hook check-json added I first ran locally:

pre-commit run --all-files

which showed the JSON files that weren't valid JSON.

Then checked some JSON with JSON Lint online.

https://jsonlint.com/

Then fixed the JSON to be valid JSON.

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

jbampton avatar Apr 03 '24 10:04 jbampton