seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[fix][docs] fix k8s dockerfile

Open liumengkai opened this issue 1 year ago • 5 comments

Purpose of this pull request

Fix dockerfile problem,now the dockerfile like this:

...
RUN cd ${SEATUNNEL_HOME}||sh bin/install-plugin.sh ${SEATUNNEL_VERSION}
...

problems:

  1. should use && not ||
  2. In dockerfile cd command can not change the work dirrectory, although we can exec the command,but we are not 'in' the ${SEATUNNEL_HOME} so command can not find plugin_config file

pathc has been tested

Check list

  • [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
  • [ ] If you are contributing the connector code, please check that the following files are updated:
    1. Update change log that in connector document. For more details you can refer to connector-v2
    2. Update plugin-mapping.properties and add new connector information in it
    3. Update the pom file of seatunnel-dist
  • [ ] Update the release-note.

liumengkai avatar Jan 09 '24 03:01 liumengkai

cc @xiamidavid00

Hisoka-X avatar Jan 09 '24 06:01 Hisoka-X

Could you follow the guide to open your fork repository CI? image

Hisoka-X avatar Jan 11 '24 02:01 Hisoka-X

Could you follow the guide to open your fork repository CI? image

sure! already done

liumengkai avatar Jan 11 '24 03:01 liumengkai

Hi @Hisoka-X I have already open my fork repository CI ,It's there anything I can do ?

liumengkai avatar Jan 12 '24 09:01 liumengkai

image

hailin0 avatar Feb 18 '24 03:02 hailin0

It looks like someone else has fixed this issue https://github.com/apache/seatunnel/pull/6475

Thanks for your contribution, this PR needs to be closed

hailin0 avatar Mar 12 '24 03:03 hailin0