seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Bug][Connector-v2][RedisSink]Fix failures caused by different cluster mode operations.

Open lightzhao opened this issue 1 year ago • 7 comments

Purpose of this pull request

If the redis mode is a cluster type, it will fail when operating the expire method. So different redis cluster types should declare and use corresponding objects.

Check list

  • [ ] Code changed are covered with tests, or it does not need tests for reason:
  • [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
  • [ ] If you are contributing the connector code, please check that the following files are updated:
    1. Update change log that in connector document. For more details you can refer to connector-v2
    2. Update plugin-mapping.properties and add new connector information in it
    3. Update the pom file of seatunnel-dist
  • [ ] Update the release-note.

lightzhao avatar Aug 14 '23 07:08 lightzhao

The code style should be fixed.

Hisoka-X avatar Aug 24 '23 08:08 Hisoka-X

hello @lightzhao Can you provide v2 connector documentation for this expressing thanks

zhilinli123 avatar Aug 29 '23 02:08 zhilinli123

BTW, whether in cluster mode or standalone mode, all operations should be abstracted into upper level interfaces

TyrantLucifer avatar Aug 29 '23 03:08 TyrantLucifer

Expire feature has some problems, I think this feature #4975 should revert and redesign it. For expire key, we should only operation once not every time after set operation.

What does it mean to operate only once, and how to implement only one operation?

lightzhao avatar Aug 29 '23 09:08 lightzhao

BTW, whether in cluster mode or standalone mode, all operations should be abstracted into upper level interfaces

This looks good, abstract class + interface can implement different client operations.

lightzhao avatar Aug 29 '23 09:08 lightzhao

hello @lightzhao Can you provide v2 connector documentation for this expressing thanks

ok, i try it.

lightzhao avatar Aug 29 '23 09:08 lightzhao

I will redesign.

lightzhao avatar Aug 29 '23 11:08 lightzhao