seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Feature][Connector-v2][RedisSink]Support redis to set expiration time.

Open lightzhao opened this issue 1 year ago • 4 comments

Purpose of this pull request

Support redis to set expiration time.

Check list

  • [ ] Code changed are covered with tests, or it does not need tests for reason:
  • [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
  • [ ] If you are contributing the connector code, please check that the following files are updated:
    1. Update change log that in connector document. For more details you can refer to connector-v2
    2. Update plugin-mapping.properties and add new connector information in it
    3. Update the pom file of seatunnel-dist
  • [ ] Update the release-note.

lightzhao avatar Jun 26 '23 10:06 lightzhao

Does the parameter make sense?

liugddx avatar Jun 27 '23 05:06 liugddx

Does the parameter make sense?

Surely it makes sense, if a key is created but no expiration is set for it, then the key will remain in memory forever. The production environment needs to set the expiration time, otherwise the memory will be greatly wasted.

lightzhao avatar Jun 27 '23 06:06 lightzhao

@EricJoy2048 @TyrantLucifer @liugddx PTAL.

lightzhao avatar Jun 30 '23 02:06 lightzhao

Can you add e2e test for this pr?

EricJoy2048 avatar Jul 06 '23 04:07 EricJoy2048

Can you add e2e test for this pr?

done.PTAL.

lightzhao avatar Jul 17 '23 06:07 lightzhao

Wait for ci to complete

liugddx avatar Jul 19 '23 10:07 liugddx

@TyrantLucifer

liugddx avatar Jul 20 '23 06:07 liugddx

@liugddx @TaoZex PTAL.

lightzhao avatar Aug 01 '23 08:08 lightzhao

@EricJoy2048 @TyrantLucifer @liugddx @TaoZex @Hisoka-X PTAL.

lightzhao avatar Aug 02 '23 09:08 lightzhao

@TyrantLucifer

ic4y avatar Aug 05 '23 09:08 ic4y

LGTM

EricJoy2048 avatar Aug 10 '23 06:08 EricJoy2048