seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Hotfix][SQL Transform] SQL transform plugin bug

Open qianxkun opened this issue 2 years ago • 7 comments

Purpose of this pull request

Check list

  • [ ] Code changed are covered with tests, or it does not need tests for reason:
  • [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
  • [ ] If you are contributing the connector code, please check that the following files are updated:
    1. Update change log that in connector document. For more details you can refer to connector-v2
    2. Update plugin-mapping.properties and add new connector information in it
    3. Update the pom file of seatunnel-dist
  • [ ] Update the release-note.

qianxkun avatar May 19 '23 08:05 qianxkun

add set Table identifier, used for the source connector that @qianxkun seaTunnelRow.setTableId(inputRow.getTableId()); PTAL: @liugddx @EricJoy2048 @rewerma

zhilinli123 avatar May 22 '23 03:05 zhilinli123

Issues:https://github.com/apache/seatunnel/issues/4784

zhilinli123 avatar May 22 '23 03:05 zhilinli123

add set Table identifier, used for the source connector that @qianxkun seaTunnelRow.setTableId(inputRow.getTableId()); PTAL: @liugddx @EricJoy2048 @rewerma

Can you add a test case?

liugddx avatar May 22 '23 03:05 liugddx

@rewerma PTAL.

TyrantLucifer avatar May 22 '23 04:05 TyrantLucifer

seaTunnelRow.setTableId(inputRow.getTableId());

Yes,add seaTunnelRow.setTableId(inputRow.getTableId()); is OK.

rewerma avatar May 22 '23 07:05 rewerma

seaTunnelRow.setTableId(inputRow.getTableId());

Yes,add seaTunnelRow.setTableId(inputRow.getTableId()); is OK.

CC @qianxkun

zhilinli123 avatar May 22 '23 12:05 zhilinli123

rebase dev fix ci error

hailin0 avatar May 26 '23 07:05 hailin0

Fix:https://github.com/apache/seatunnel/pull/4819

zhilinli123 avatar Jun 06 '23 03:06 zhilinli123

This issue has already been fixed in https://github.com/apache/seatunnel/pull/4819.

ic4y avatar Aug 06 '23 13:08 ic4y