seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[hotfix][kafka] Fix the problem that the partition information cannot be obtained when kafka is restored

Open liugddx opened this issue 2 years ago • 7 comments

close #4763

Purpose of this pull request

Check list

  • [ ] Code changed are covered with tests, or it does not need tests for reason:
  • [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
  • [ ] If you are contributing the connector code, please check that the following files are updated:
    1. Update change log that in connector document. For more details you can refer to connector-v2
    2. Update plugin-mapping.properties and add new connector information in it
    3. Update the pom file of seatunnel-dist
  • [ ] Update the release-note.

liugddx avatar May 16 '23 15:05 liugddx

Can you add an test case reference https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceTwoPipelineIT.java to test this?

EricJoy2048 avatar May 17 '23 12:05 EricJoy2048

Can you add an test case reference https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-e2e/seatunnel-engine-e2e/connector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/ClusterFaultToleranceTwoPipelineIT.java to test this?

I've tested it locally and it works fine.

image

liugddx avatar May 17 '23 14:05 liugddx

Task recovery process assignSplit() must be called after registerReader().

liugddx avatar May 17 '23 14:05 liugddx

#4773

liugddx avatar May 17 '23 15:05 liugddx

LGTM, A small suggestion, I do not recommend modifying the code style while fixing bugs, as it will increase the difficulty of reviewing.

@hailin0 @ic4y PTAL.

EricJoy2048 avatar May 17 '23 15:05 EricJoy2048

LGTM, A small suggestion, I do not recommend modifying the code style while fixing bugs, as it will increase the difficulty of reviewing.

Thanks for reminding, I saw the warning, so I formatted the code. In the future, I will pay attention to this point.

liugddx avatar May 18 '23 01:05 liugddx

@TyrantLucifer PTAL again.

EricJoy2048 avatar May 23 '23 09:05 EricJoy2048