seatunnel
seatunnel copied to clipboard
apache
[Improve][seatunnel-engine-common] move serializer to common
Purpose of this pull request
Check list
- [ ] Code changed are covered with tests, or it does not need tests for reason:
- [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
- [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
- [ ] If you are contributing the connector code, please check that the following files are updated:
- Update change log that in connector document. For more details you can refer to connector-v2
- Update plugin-mapping.properties and add new connector information in it
- Update the pom file of seatunnel-dist
Other modules need this function? A lot of modules depend on common module, add extra dependency in common module can cause the jar so fat. If only st-engine using the proto serializer I think it put in engine module might be better.
cc @hailin0 @Hisoka-X @ic4y @EricJoy2048 @CalvinKirs @ashulin
Hey guys, what do you think about it?
Other modules need this function? A lot of modules depend on common module, add extra dependency in common module can cause the jar so fat. If only st-engine using the proto serializer I think it put in engine module might be better.
cc @hailin0 @Hisoka-X @ic4y @EricJoy2048 @CalvinKirs @ashulin
Hey guys, what do you think about it?
+1
Other modules need this function? A lot of modules depend on common module, add extra dependency in common module can cause the jar so fat. If only st-engine using the proto serializer I think it put in engine module might be better.↳
cc @hailin0 @Hisoka-X @ic4y @EricJoy2048 @CalvinKirs @ashulin
Hey guys, what do you think about it?↳
yes, it belongs to the engine module.
Other modules need this function? A lot of modules depend on common module, add extra dependency in common module can cause the jar so fat. If only st-engine using the proto serializer I think it put in engine module might be better.↳ cc @hailin0 @Hisoka-X @ic4y @EricJoy2048 @CalvinKirs @ashulin Hey guys, what do you think about it?↳
yes, it belongs to the engine module.
Ok, I will migrate to the engine module.
should delete this comment
Btw, A better way is to serialize as a separate module, and we may support other ways in the future, such as protobuf, json and more
Btw, A better way is to serialize as a separate module, and we may support other ways in the future, such as protobuf, json and more
Done. PTAL thanks.