seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Feature][seatunnel-engine][checkpoint-storage]add oss support for checkpoint storing.

Open Grypse opened this issue 2 years ago • 11 comments

Check list

  • [ ] Code changed are covered with tests, or it does not need tests for reason:
  • [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
  • [ ] If you are contributing the connector code, please check that the following files are updated:
    1. Update change log that in connector document. For more details you can refer to connector-v2
    2. Update plugin-mapping.properties and add new connector information in it
    3. Update the pom file of seatunnel-dist

Grypse avatar Dec 15 '22 09:12 Grypse

@liugddx @Hisoka-X Please help me review this, thanks!

Grypse avatar Dec 16 '22 02:12 Grypse

@hailin0 Please help me review this, thanks.

Grypse avatar Dec 16 '22 04:12 Grypse

@CalvinKirs Please help me review this.

Grypse avatar Dec 19 '22 02:12 Grypse

@CalvinKirs Please help me review this.

cc @CalvinKirs

TyrantLucifer avatar Dec 19 '22 06:12 TyrantLucifer

I happen to have a question that I can discuss here. Now our checkpoint persistence implementation comes in through SPI, so we need to know how to release the jar under the routine? Is it the same as the connector or is it directly packaged together?

liugddx avatar Dec 19 '22 07:12 liugddx

I happen to have a question that I can discuss here. Now our checkpoint persistence implementation comes in through SPI, so we need to know how to release the jar under the routine? Is it the same as the connector or is it directly packaged together?

Now, the checkpoint storage has been packaged with seatunnel engine starter together. But the hadoop dependencies does not provided!

Grypse avatar Dec 19 '22 08:12 Grypse

I happen to have a question that I can discuss here. Now our checkpoint persistence implementation comes in through SPI, so we need to know how to release the jar under the routine? Is it the same as the connector or is it directly packaged together?

Now, the checkpoint storage has been packaged with seatunnel engine starter together. But the hadoop dependencies does not provided!

We can process release question with other issue. This just support oss schema for hdfs. @liugddx

Grypse avatar Dec 19 '22 10:12 Grypse

Can you provide screenshots of the test?

liugddx avatar Dec 19 '22 10:12 liugddx

Can you provide screenshots of the test?

UT settings: image

UT write checkpoints info: image

All test passed: image

Grypse avatar Dec 19 '22 10:12 Grypse

@TyrantLucifer PTAL

liugddx avatar Dec 22 '22 03:12 liugddx

please fix CI.

liugddx avatar Dec 23 '22 02:12 liugddx