seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Feature][Core] Override env parameters via command line arguments

Open liugddx opened this issue 2 years ago • 5 comments

Search before asking

  • [X] I had searched in the feature and found no similar feature requirement.

Description

Override env parameters via command line arguments

Usage Scenario

No response

Related issues

No response

Are you willing to submit a PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

liugddx avatar Nov 21 '22 11:11 liugddx

Do we now use command line parameters to directly replace the parameters in config or use placeholder replacement in config?

  1. direct replacement start-seatunnel-flink-connector-v2.sh -c config.conf -i job.name=test
env {
job.name = seatunnel
}
  1. placeholder replacement

start-seatunnel-flink-connector-v2.sh -c config.conf -i jobName=test

env {
job.name = ${jobName}
}

liugddx avatar Nov 29 '22 12:11 liugddx

Do we now use command line parameters to directly replace the parameters in config or use placeholder replacement in config?

  1. direct replacement start-seatunnel-flink-connector-v2.sh -c config.conf -i job.name=test
env {
job.name = seatunnel
}
  1. placeholder replacement

start-seatunnel-flink-connector-v2.sh -c config.conf -i jobName=test

env {
job.name = ${jobName}
}

The second method is now supported, but sometimes the placeholder will not be configured

liugddx avatar Nov 29 '22 13:11 liugddx

Do we now use command line parameters to directly replace the parameters in config or use placeholder replacement in config?

  1. direct replacement start-seatunnel-flink-connector-v2.sh -c config.conf -i job.name=test
env {
job.name = seatunnel
}
  1. placeholder replacement

start-seatunnel-flink-connector-v2.sh -c config.conf -i jobName=test

env {
job.name = ${jobName}
}

The second method is now supported, but sometimes the placeholder will not be configured

@Hisoka-X @EricJoy2048 @TyrantLucifer Any suggestions?

liugddx avatar Nov 29 '22 13:11 liugddx

I think method 1 can only support replace parameter in env. But not use -i, use -p or other. Method 2 is good for replace the placeholder.

Hisoka-X avatar Nov 30 '22 02:11 Hisoka-X

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Jan 01 '23 00:01 github-actions[bot]

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

github-actions[bot] avatar Jan 09 '23 00:01 github-actions[bot]