seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Improve][Clickhouse-V2] Clickhouse Support Geo type

Open FWLamb opened this issue 2 years ago • 4 comments

Purpose of this pull request

Clickhouse Sink Support write Geo type https://github.com/apache/incubator-seatunnel/issues/3101 Clickhouse Source also Support Geo type.

Check list

  • [x] Code changed are covered with tests, or it does not need tests for reason:
  • [x] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

FWLamb avatar Oct 19 '22 07:10 FWLamb

Maybe we need to change the version of clickhouse-jdbc in the future. https://github.com/ClickHouse/clickhouse-jdbc/issues/1112

FWLamb avatar Oct 19 '22 07:10 FWLamb

Please use e2e to test these type.

Hisoka-X avatar Oct 21 '22 09:10 Hisoka-X

Point and Ring data types passed the e2e test. Polygon and MultiPolygon cannot be used temporarily because of a bug in clickhouse jdbc. Please track https://github.com/ClickHouse/clickhouse-jdbc/issues/1112

FWLamb avatar Oct 21 '22 09:10 FWLamb

Like this https://github.com/apache/incubator-seatunnel/pull/3047/files#diff-74e1e7a8b81b6f0f364b14de8bf7f0957bcea7d13f1ce23c61be650844fc2ecd , you should turn on clickhouse e2e test.

Hisoka-X avatar Oct 21 '22 09:10 Hisoka-X

@Hisoka-X PTAL

FWLamb avatar Oct 31 '22 11:10 FWLamb

Please add the improve to Clickhouse Connector doc and add the changed log reference https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/source/Redis.md#next-version

all right

FWLamb avatar Nov 01 '22 07:11 FWLamb

https://github.com/apache/incubator-seatunnel/pull/3067 https://github.com/apache/incubator-seatunnel/pull/3047 @EricJoy2048 Do the above two PRs also need to be added?

FWLamb avatar Nov 01 '22 07:11 FWLamb

#3067 #3047 @EricJoy2048 Do the above two PRs also need to be added?

Yes, add it together.

Hisoka-X avatar Nov 01 '22 07:11 Hisoka-X

#3067 #3047 @EricJoy2048 Do the above two PRs also need to be added?

Yes, add it together.

all right

FWLamb avatar Nov 01 '22 07:11 FWLamb