seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Feature][Connector-V2] Jdbc connector support SAP HANA Source & SAP HANA Sink.

Open FlechazoW opened this issue 3 years ago • 7 comments

Purpose of this pull request

[Connector-V2][JDBC-connector] support Jdbc dm

Check list

  • [x] Code changed are covered with tests, or it does not need tests for reason:
  • [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

FlechazoW avatar Oct 08 '22 08:10 FlechazoW

Is it necessary to have init-datasource as a separate file?I think the paperwork is getting a little messy,How about writing it straight into code?

liugddx avatar Oct 08 '22 08:10 liugddx

Is it necessary to have init-datasource as a separate file?I think the paperwork is getting a little messy,How about writing it straight into code?

Nice thought.

FlechazoW avatar Oct 08 '22 09:10 FlechazoW

The code style should be fixed.

Hisoka-X avatar Oct 09 '22 09:10 Hisoka-X

The code style should be fixed.

Done @Hisoka-X

FlechazoW avatar Oct 09 '22 09:10 FlechazoW

@FlechazoW The Integration Test have some problems should be fixed.

Hisoka-X avatar Oct 11 '22 05:10 Hisoka-X

trigger CI

CalvinKirs avatar Oct 12 '22 10:10 CalvinKirs

Are SAP_HANA_BIGINT, SAP_HANA_INTEGER, SAP_HANA_SMALLINT all tested with SHORT_TYPE? doesn't look right

ic4y avatar Nov 25 '22 02:11 ic4y