seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Core][Translation] Support Primitive Array convert to References Array

Open Hisoka-X opened this issue 2 years ago • 3 comments

Search before asking

  • [X] I had searched in the feature and found no similar feature requirement.

Description

At now, If we set value use Primitive Array like double[], will happen convert exception, because we only support Double[], all primitive type have same problem. image So we should convert Primitive Array to References Array when we convert SeaTunnelRow to EngineRow(Spark/Flink). The detail in org.apache.seatunnel.translation.serialization.RowConverter

Usage Scenario

No response

Related issues

No response

Are you willing to submit a PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

Hisoka-X avatar Sep 19 '22 03:09 Hisoka-X

For array type convert I had fixed in pr #2479, I see Primitive Array only one type of byte is implemented. Do you mean that array convert is also has some problems in flink engine?

TyrantLucifer avatar Sep 19 '22 06:09 TyrantLucifer

For array type convert I had fixed in pr #2479, I see Primitive Array only one type of byte is implemented. Do you mean that array convert is also has some problems in flink engine?

Yes, we should ensure consistent data types instead of including Primitive Array and References Array during data transfer. Confused to downstream components that use data, since we only support References Array, we need to convert Primitive Array to References Array when Source produces SeaTunnelRow. The reason for not entrusting this task to the Source Connector is to reduce the burden on the Source implementer.

Hisoka-X avatar Sep 19 '22 06:09 Hisoka-X

For array type convert I had fixed in pr #2479, I see Primitive Array only one type of byte is implemented. Do you mean that array convert is also has some problems in flink engine?

Yes, we should ensure consistent data types instead of including Primitive Array and References Array during data transfer. Confused to downstream components that use data, since we only support References Array, we need to convert Primitive Array to References Array when Source produces SeaTunnelRow. The reason for not entrusting this task to the Source Connector is to reduce the burden on the Source implementer.

Please assign it to me. Thx.

TyrantLucifer avatar Sep 19 '22 06:09 TyrantLucifer

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Oct 20 '22 00:10 github-actions[bot]

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

github-actions[bot] avatar Nov 19 '22 00:11 github-actions[bot]

For array type convert I had fixed in pr #2479, I see Primitive Array only one type of byte is implemented. Do you mean that array convert is also has some problems in flink engine?

Yes, we should ensure consistent data types instead of including Primitive Array and References Array during data transfer. Confused to downstream components that use data, since we only support References Array, we need to convert Primitive Array to References Array when Source produces SeaTunnelRow. The reason for not entrusting this task to the Source Connector is to reduce the burden on the Source implementer.

Please assign it to me. Thx.

Hi, @TyrantLucifer What is the status of this issue?

EricJoy2048 avatar Nov 21 '22 14:11 EricJoy2048

For array type convert I had fixed in pr #2479, I see Primitive Array only one type of byte is implemented. Do you mean that array convert is also has some problems in flink engine?

Yes, we should ensure consistent data types instead of including Primitive Array and References Array during data transfer. Confused to downstream components that use data, since we only support References Array, we need to convert Primitive Array to References Array when Source produces SeaTunnelRow. The reason for not entrusting this task to the Source Connector is to reduce the burden on the Source implementer.

Please assign it to me. Thx.

Hi, @TyrantLucifer What is the status of this issue?

Can be closed.

TyrantLucifer avatar Nov 21 '22 14:11 TyrantLucifer

For array type convert I had fixed in pr #2479, I see Primitive Array only one type of byte is implemented. Do you mean that array convert is also has some problems in flink engine?

Yes, we should ensure consistent data types instead of including Primitive Array and References Array during data transfer. Confused to downstream components that use data, since we only support References Array, we need to convert Primitive Array to References Array when Source produces SeaTunnelRow. The reason for not entrusting this task to the Source Connector is to reduce the burden on the Source implementer.

Please assign it to me. Thx.

Hi, @TyrantLucifer What is the status of this issue?

Can be closed.

Thanks.

EricJoy2048 avatar Nov 21 '22 14:11 EricJoy2048