seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Bug][seatunnel-connector-spark-tidb] Spark tidb Connector Hadoop dependency excluded

Open Carl-Zhou-CN opened this issue 2 years ago • 5 comments

Purpose of this pull request

Check list

  • [ ] Code changed are covered with tests, or it does not need tests for reason:
  • [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs

Carl-Zhou-CN avatar Sep 09 '22 10:09 Carl-Zhou-CN

#2698

Carl-Zhou-CN avatar Sep 09 '22 10:09 Carl-Zhou-CN

@hailin0 please help to review it

Carl-Zhou-CN avatar Sep 13 '22 01:09 Carl-Zhou-CN

Can you add e2e-testcase(spark)?

reference https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-spark-e2e

hailin0 avatar Sep 13 '22 02:09 hailin0

@hailin0 I didn't find anything about TiDB in E2E, do I need to add a module for this? If so, I can try, and how can this PR review be approved to begin

Carl-Zhou-CN avatar Sep 13 '22 08:09 Carl-Zhou-CN

Hi, Please fix license check and codestyle. Thanks!

Hisoka-X avatar Sep 17 '22 11:09 Hisoka-X

hi, thanks for your contribution, dev branch will no longer maintain the V1 version of the connector, so I will close this PR, If you are interested in this, you can contribute the corresponding V2Connector https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-connectors-v2

CalvinKirs avatar Jan 17 '23 07:01 CalvinKirs