seatunnel
seatunnel copied to clipboard
[Feature][Flink-SQL-connector] add flink sql connector hbase 1.2&2.2 and docs
Purpose of this pull request
issue ref: https://github.com/apache/incubator-seatunnel/issues/1930
Check list
- [ ] Code changed are covered with tests, or it does not need tests for reason:
- [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
- [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
Seem like you should add license in known-dependencies.txt
PR to be UPDATED.
Hi, @ruanwenjun and @BenJFan , I'm afraid the git workflow might need some improvement.
I tried the failed command in my machine (MacOS), it works.
I think the failure might caused by maven concurrency building '-T'
./mvnw -T 2C -B clean verify -Dmaven.test.skip=false -Dcheckstyle.skip=true -Dscalastyle.skip=true -Dlicense.skipAddThirdParty=true --no-snapshot-updates
I suggest to modify it with no concurrency thread build.
What do you thinks?
Hi, @ruanwenjun and @BenJFan , I'm afraid the git workflow might need some improvement.
I tried the failed command in my machine (MacOS), it works.
I think the failure might caused by maven concurrency building '-T'
./mvnw -T 2C -B clean verify -Dmaven.test.skip=false -Dcheckstyle.skip=true -Dscalastyle.skip=true -Dlicense.skipAddThirdParty=true --no-snapshot-updates
I suggest to modify it with no concurrency thread build.
What do you thinks?
What do you seem to be missing? This CI will list the newly added dependencies,
Hi, @ruanwenjun and @BenJFan , I'm afraid the git workflow might need some improvement.
I tried the failed command in my machine (MacOS), it works.
I think the failure might caused by maven concurrency building '-T'
./mvnw -T 2C -B clean verify -Dmaven.test.skip=false -Dcheckstyle.skip=true -Dscalastyle.skip=true -Dlicense.skipAddThirdParty=true --no-snapshot-updates
I suggest to modify it with no concurrency thread build.
What do you thinks?
Yeah, if you may get error if you use -T 2C to build in your laptop. But I don't think we need to remove the concurrency setting, since this is used for GitHub CI, you can just remove this when you build on your laptop.
Hi, @ruanwenjun and @BenJFan , I'm afraid the git workflow might need some improvement. I tried the failed command in my machine (MacOS), it works. I think the failure might caused by maven concurrency building '-T'
./mvnw -T 2C -B clean verify -Dmaven.test.skip=false -Dcheckstyle.skip=true -Dscalastyle.skip=true -Dlicense.skipAddThirdParty=true --no-snapshot-updates
I suggest to modify it with no concurrency thread build. What do you thinks?
What do you seem to be missing? This CI will list the newly added dependencies,
UT failed with this message "Error: Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.3.0:single (bin) on project seatunnel-dist: Execution bin of goal org.apache.maven.plugins:maven-assembly-plugin:3.3.0:single failed: basedir D:\a\incubator-seatunnel\incubator-seatunnel\seatunnel-dist..\seatunnel-connectors\seatunnel-connectors-flink-sql-dist\target\lib does not exist -> [Help 1]"
Just as I comment above, the maven concurrency build with -T C2
might cause this problem. I run the same command on my laptop, it works.
To verify this, I submit a new commit to remove the -T C2
in git worklow, now the step in CI passed.
So I think we need to update the Github CI workflow (already present in this PR) to avoid the misjudgement. Or other improvement of github CI works is ok.
cc @CalvinKirs @ruanwenjun
@ruanwenjun @CalvinKirs Do this PR can merge?
@ruanwenjun @CalvinKirs Do this PR can merge?
Hold it now. cc @BenJFan
Hi, what's news about this pr?
This pr is closed because it has not responded for too long. If necessary, please reopen it