seatunnel icon indicating copy to clipboard operation
seatunnel copied to clipboard

[Fix][Connector-doris] DorisStreamLoad loading state mismanagement causes RecordBuffer infinite loop during shutdown

Open Mrhs121 opened this issue 1 month ago • 7 comments

Purpose of this pull request

close https://github.com/apache/seatunnel/issues/10059

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

  • [ ] If any new Jar binary package adding in your PR, please add License Notice according New License Guide
  • [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
  • [ ] If you are contributing the connector code, please check that the following files are updated:
    1. Update plugin-mapping.properties and add new connector information in it
    2. Update the pom file of seatunnel-dist
    3. Add ci label in label-scope-conf
    4. Add e2e testcase in seatunnel-e2e
    5. Update connector plugin_config

Mrhs121 avatar Nov 13 '25 04:11 Mrhs121

When will the flushing=false state be reset?

davidzollo avatar Nov 13 '25 13:11 davidzollo

Thanks for pointing this out. The flushing flag should be reset to false immediately after the flush operation completest. I'll include the fix for resetting the flushing state along with the new E2E test in the next commit.

When will the flushing=false state be reset?

Thanks for pointing this out. The flushing flag should be reset to false immediately after the flush operation completest. I'll include the fix for resetting the flushing state along with the new E2E test in the next commit.

FYI, I noticed the CI failure was due to the job exceeding the 10-minute timeout limit.

Mrhs121 avatar Nov 14 '25 02:11 Mrhs121

Thanks for pointing this out. The flushing flag should be reset to false immediately after the flush operation completest. I'll include the fix for resetting the flushing state along with the new E2E test in the next commit.

When will the flushing=false state be reset?

Thanks for pointing this out. The flushing flag should be reset to false immediately after the flush operation completest. I'll include the fix for resetting the flushing state along with the new E2E test in the next commit.

FYI, I noticed the CI failure was due to the job exceeding the 10-minute timeout limit.

Good. you can also help fix CI ^_^ Usually reviewers will review a new PR when CI passed.

By the way, I think we can have a more in-depth communication to help you get familiar with SeaTunnel. Feel free to contact me on LinkedIn (David Zollo) or WeChat (taskflow). When adding me, please let me know your GitHub ID

davidzollo avatar Nov 14 '25 05:11 davidzollo

I have provide a pure test case https://github.com/apache/seatunnel/pull/10069 to reproduction https://github.com/apache/seatunnel/issues/10059

Mrhs121 avatar Nov 14 '25 16:11 Mrhs121

I have provide a pure test case #10069 to reproduction #10059

We can merge #10069 into the current PR to verify that this issue will not occur.

zhangshenghang avatar Nov 17 '25 23:11 zhangshenghang

@zhangshenghang I made some new changes, please help review it when you have time, thank you.

Mrhs121 avatar Nov 21 '25 09:11 Mrhs121

@zhangshenghang I made some new changes, please help review it when you have time, thank you.

Mrhs121 avatar Dec 10 '25 12:12 Mrhs121

@zhangshenghang Hi shenghang, could you please review this again? Please let me know if there’s anything else I need to do.

Mrhs121 avatar Dec 17 '25 11:12 Mrhs121