samza icon indicating copy to clipboard operation
samza copied to clipboard

SAMZA-1559 moving hello-samza repo to samza repo and put in samza-samples directory

Open fredji97 opened this issue 6 years ago • 7 comments

Tested and jobs can be deployed in the new place. After this is committed, we will do the following two in order:

  1. adjust the documentation to use the sample jobs from the new place;
  2. remove the old hello-samza repo.

fredji97 avatar May 10 '18 21:05 fredji97

There is an earlier ticket that covers this issue as well. Please check https://issues.apache.org/jira/browse/SAMZA-205 to see how much this PR covers the issues discussed in that thread.

nickpan47 avatar May 10 '18 22:05 nickpan47

@fredji97 Doesn't seem like the deploy directory be a part of this commit. Are you moving a clean copy or a local copy?

prateekm avatar May 10 '18 22:05 prateekm

@nickpan47, thanks for the referenced JIRA.

I am considering breaking the task of this SAMZA-205 into 4 steps:

  1. Move hello-samza repo to samza-samples directory of samza repo;
  2. Update the documentation related hello-samza to use the code in samza/samza-samples;
  3. Delete hello-samza repo;
  4. build a gradle target such as samzaSampleIntegrationTests to hook the tests in samza/samza-samples.

And this PR is the first step. After this one is done, 2&3 need to be done soon as well to bring it on par with the current situation. And 4 then can be done independently.

fredji97 avatar May 11 '18 19:05 fredji97

@prateekm Thanks for checking the directories. Actually, deploy directory is generated when running the test. We prefer not to want to check the deploy directory into the repo.

fredji97 avatar May 11 '18 19:05 fredji97

@fredji97 also, have you tried moving the files in the existing hello-samza repo to this repo such that it preserves git history? If not, we should try that first before copying files over.

prateekm avatar May 11 '18 19:05 prateekm

@prateekm Thanks for the comments. I have pulled in the hello-samza git log history as well.

fredji97 avatar May 11 '18 23:05 fredji97

@fredji97 I think after yi pan's serializable operator changes, samza-hello-samza repository does not build with samza open source head. I'm fixing the compilation problems in samza-hello-samza. Please update the PR with my fixes and then merge it.

shanthoosh avatar Jul 27 '18 01:07 shanthoosh