samza icon indicating copy to clipboard operation
samza copied to clipboard

SAMZA-1542 refactor config classes in samza-core java to hide non-necessary interfaces

Open fredji97 opened this issue 7 years ago • 1 comments

With previous inheritance, it exposed everything from Config class, which is a bad practice and is error prone. We are refactoring it to use composition over inheritance make it more robust.

fredji97 avatar Jan 03 '18 00:01 fredji97

Hey @fredji97 , Thanks for this PR. While I'm +1 to your idea, I'm trying to ensure that the open-source codebase doesn't remain in a state where some Config classes follow inheritance while others follow composition for a long period of time. Ideally, I would love to make all changes in one-shot throughout the Samza code-base. It need not have to be a single PR but would be nice if you have all necessary PRs ready and if they can be merged in quick succession. cc: @prateekm @nickpan47

vjagadish1989 avatar Jan 17 '18 17:01 vjagadish1989