rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #8084] fix typo

Open hakusai22 opened this issue 1 year ago • 3 comments

Which Issue(s) This PR Fixes

Fixes #issue_id

Brief Description

fix doc and code typo

How Did You Test This Change?

hakusai22 avatar Apr 30 '24 12:04 hakusai22

Codecov Report

Attention: Patch coverage is 17.50000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 42.82%. Comparing base (d60198f) to head (ee9f3d2).

Files Patch % Lines
...mq/broker/topic/TopicQueueMappingCleanService.java 0.00% 8 Missing :warning:
...ocketmq/broker/processor/PullMessageProcessor.java 0.00% 3 Missing :warning:
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 0.00% 2 Missing :warning:
...g/apache/rocketmq/common/filter/impl/Operator.java 0.00% 2 Missing :warning:
...mq/remoting/protocol/body/PopProcessQueueInfo.java 0.00% 2 Missing :warning:
...n/java/org/apache/rocketmq/test/util/FileUtil.java 0.00% 2 Missing :warning:
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 0.00% 1 Missing :warning:
...rocketmq/client/impl/consumer/PopProcessQueue.java 0.00% 1 Missing :warning:
...apache/rocketmq/common/filter/impl/PolishExpr.java 0.00% 1 Missing :warning:
.../common/statistics/StatisticsBriefInterceptor.java 0.00% 1 Missing :warning:
... and 10 more
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8085      +/-   ##
=============================================
- Coverage      42.89%   42.82%   -0.07%     
+ Complexity     10401    10382      -19     
=============================================
  Files           1274     1274              
  Lines          88956    88956              
  Branches       11438    11438              
=============================================
- Hits           38154    38099      -55     
- Misses         46096    46148      +52     
- Partials        4706     4709       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 30 '24 13:04 codecov-commenter

Hi @hakusai22 , Could you help resolve the conflict?

RongtongJin avatar May 22 '24 00:05 RongtongJin

Hi @hakusai22 , Could you help resolve the conflict?

does

Hi @hakusai22 , Could you help resolve the conflict?

done . Why? The bug I found was merged in by others in advance https://github.com/apache/rocketmq/pull/8091

hakusai22 avatar May 22 '24 01:05 hakusai22