rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #8070] Optimize the submitConsumeRequest and remove unnecessary exception catching

Open biningo opened this issue 1 year ago • 6 comments

Which Issue(s) This PR Fixes

Fixes #8070

biningo avatar Apr 26 '24 13:04 biningo

If the number of messages or the consumeBatchSize is zero, it will work fine.

biningo avatar Apr 26 '24 13:04 biningo

In submitConsumeRequest submitConsumeRequestLater is unnecessary.

biningo avatar Apr 26 '24 13:04 biningo

Maven test fails in Ubuntu, but it seems to have nothing to do with this PR. @humkum Can you help me? Thanks!

biningo avatar Apr 30 '24 08:04 biningo

Merge develop branch to fix the ut. @biningo

cserwen avatar May 10 '24 02:05 cserwen

Merge develop branch to fix the ut. @biningo

OK, I've merged. Thanks for your help! :)

biningo avatar May 11 '24 14:05 biningo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.90%. Comparing base (159a603) to head (b8a638d).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8071      +/-   ##
=============================================
- Coverage      42.94%   42.90%   -0.05%     
+ Complexity     10387    10372      -15     
=============================================
  Files           1270     1270              
  Lines          88694    88679      -15     
  Branches       11401    11397       -4     
=============================================
- Hits           38092    38045      -47     
- Misses         45914    45940      +26     
- Partials        4688     4694       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 13 '24 02:05 codecov-commenter

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar May 15 '25 00:05 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar May 18 '25 00:05 github-actions[bot]