[ISSUE #8053] Return SYSTEM_BUSY if PutMessageStatus is OS_PAGE_CACHE_BUSY
Which Issue(s) This PR Fixes
Fixes #8053
It is correct to change the response code, but we need more discussion on whether client should retry on this scenario. Personally I think the client should retry by default to avoid producing failure.
I agree with you
It is correct to change the response code, but we need more discussion on whether client should retry on this scenario. Personally I think the client should retry by default to avoid producing failure.
There has been a lot of discussion about whether system_busy should be retried. I personally support retrying. For details, please refer to https://github.com/apache/rocketmq/pull/5845 @yuz10
@biningo merge develop to fix the ut
@biningo merge develop to fix the ut
okay, I have merged.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 42.88%. Comparing base (
159a603) to head (e148e32). Report is 5 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #8054 +/- ##
=============================================
- Coverage 42.94% 42.88% -0.07%
+ Complexity 10387 10369 -18
=============================================
Files 1270 1270
Lines 88694 88693 -1
Branches 11401 11401
=============================================
- Hits 38092 38037 -55
- Misses 45914 45949 +35
- Partials 4688 4707 +19
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @yuz10 #5845 already merged. Please review again.