rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #8053] Return SYSTEM_BUSY if PutMessageStatus is OS_PAGE_CACHE_BUSY

Open biningo opened this issue 1 year ago • 6 comments

Which Issue(s) This PR Fixes

Fixes #8053

biningo avatar Apr 23 '24 14:04 biningo

It is correct to change the response code, but we need more discussion on whether client should retry on this scenario. Personally I think the client should retry by default to avoid producing failure.

I agree with you

biningo avatar Apr 26 '24 13:04 biningo

It is correct to change the response code, but we need more discussion on whether client should retry on this scenario. Personally I think the client should retry by default to avoid producing failure.

There has been a lot of discussion about whether system_busy should be retried. I personally support retrying. For details, please refer to https://github.com/apache/rocketmq/pull/5845 @yuz10

cserwen avatar Apr 28 '24 06:04 cserwen

@biningo merge develop to fix the ut

cserwen avatar May 10 '24 03:05 cserwen

@biningo merge develop to fix the ut

okay, I have merged.

biningo avatar May 14 '24 13:05 biningo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.88%. Comparing base (159a603) to head (e148e32). Report is 5 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8054      +/-   ##
=============================================
- Coverage      42.94%   42.88%   -0.07%     
+ Complexity     10387    10369      -18     
=============================================
  Files           1270     1270              
  Lines          88694    88693       -1     
  Branches       11401    11401              
=============================================
- Hits           38092    38037      -55     
- Misses         45914    45949      +35     
- Partials        4688     4707      +19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 15 '24 02:05 codecov-commenter

Hi @yuz10 #5845 already merged. Please review again.

biningo avatar May 15 '24 06:05 biningo