rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #7466] Added fast failure in adminBrokerThreadPoolQueue (#7466)

Open yp969803 opened this issue 1 year ago • 2 comments

Which Issue(s) This PR Fixes

Fixes #7466

Brief Description

Added fast failure in adminBrokerThreadPoolQueue

How Did You Test This Change?

mvn test

yp969803 avatar Jan 29 '24 19:01 yp969803

@weihubeats @RongtongJin can you verify this pr

yp969803 avatar Jan 29 '24 19:01 yp969803

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1242a58) 0.00% compared to head (606c113) 42.94%. Report is 12 commits behind head on develop.

Files Patch % Lines
.../java/org/apache/rocketmq/common/BrokerConfig.java 66.66% 1 Missing :warning:
Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #7798       +/-   ##
==============================================
+ Coverage           0   42.94%   +42.94%     
- Complexity         0     9896     +9896     
==============================================
  Files              0     1190     +1190     
  Lines              0    85936    +85936     
  Branches           0    11070    +11070     
==============================================
+ Hits               0    36901    +36901     
- Misses             0    44460    +44460     
- Partials           0     4575     +4575     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jan 29 '24 20:01 codecov-commenter

consumerManagerThreadPoolQueue also need fast failure, could you please add it ?

guyinyou avatar Feb 21 '24 06:02 guyinyou