rocketmq
rocketmq copied to clipboard
[ISSUE #7662] fix: updateAccessConfig when groupPerms is empty
Which Issue(s) This PR Fixes
Fixes #7662
Brief Description
org.apache.rocketmq.common.UtilAll#join return "" when list is empty, When I updateAccessConfig, the method UtilAll.split(requestHeader.getGroupPerms(), ",") Returns a collection of empty strings. The method org.apache.rocketmq.acl.common.Permission#checkResourcePerms will not running well.
How Did You Test This Change?
yes, I updateAccessConfig successfully.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
6fce427
) 43.21% compared to head (9c2e9f8
) 43.18%. Report is 9 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #7664 +/- ##
=============================================
- Coverage 43.21% 43.18% -0.04%
- Complexity 9815 9818 +3
=============================================
Files 1165 1165
Lines 84548 84548
Branches 10980 10980
=============================================
- Hits 36534 36508 -26
- Misses 43472 43501 +29
+ Partials 4542 4539 -3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.