apache
Micrometer observation
This is a draft PR since there are a couple of questions / issues that need to be addressed
- I've created a separate
micrometerpackage so that the code is isolated, but I can move it next to OpenTracing packages - I tried to follow the current (24.08.2023) Semantic conventions for messaging https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/messaging/ but need help with all the remaining
TODO:comments as far as tags are concerned - Where should we put the documentation to this integration?
- How do we deal with scoping (span scopes) when consuming batches? How often do we process a single message? If we left an open scope for a span how would users then close it? Can it be done automatically?
Which Issue(s) This PR Fixes
https://github.com/apache/rocketmq/issues/7055
Brief Description
Adds Micrometer Observation support via the ConsumeMessageHook and SendMessageHook
How Did You Test This Change?
I've added 2 tests that reuse OpenTracing's testing approach. They test for the presence of spans and metrics.
Got the following results in Zipkin:
.Receive Span
.Produce Span
hey @vintagewang @YangJodie , WDYT about this feature? Are you willing to accept it in any way?
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.