rocketmq
rocketmq copied to clipboard
[ISSUE #7143] Add topic config tools search
Which Issue(s) This PR Fixes
Fixes #7143
Brief Description
How Did You Test This Change?
@Ceilzcx Hi please link this pr to related issue
done it
Codecov Report
Merging #7167 (587d22c) into develop (f534501) will decrease coverage by
0.07%. Report is 3 commits behind head on develop. The diff coverage is30.30%.
@@ Coverage Diff @@
## develop #7167 +/- ##
=============================================
- Coverage 42.52% 42.45% -0.07%
+ Complexity 9357 9350 -7
=============================================
Files 1149 1150 +1
Lines 82043 82074 +31
Branches 10701 10705 +4
=============================================
- Hits 34889 34847 -42
- Misses 42792 42863 +71
- Partials 4362 4364 +2
| Files Changed | Coverage Δ | |
|---|---|---|
| .../apache/rocketmq/tools/command/MQAdminStartup.java | 0.00% <0.00%> (ø) |
|
| .../tools/command/topic/GetTopicConfigSubCommand.java | 30.00% <30.00%> (ø) |
|
| ...s/command/broker/BrokerConsumeStatsSubCommand.java | 40.27% <100.00%> (ø) |
... and 19 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
you can refer to GetConsumerConfigSubCommand.
thank you for you comment,like this?
Is there anything else i need to add? @mxsm please review it? thanks
changes LGTM, but there are test failures, please check out :)
sorry, I'm not understand, I didn't change the code about rocketmq-store module, and I can pass the test in local, i don't know how to fix it
changes LGTM, but there are test failures, please check out :)
sorry, I'm not understand, I didn't change the code about rocketmq-store module, and I can pass the test in local, i don't know how to fix it
retry?
changes LGTM, but there are test failures, please check out :)
sorry, I'm not understand, I didn't change the code about rocketmq-store module, and I can pass the test in local, i don't know how to fix it
retry?
well, the first when I pr has no failures
you see re-run the jobs? I don't have permission.
try git rebase master and push commits, it will re-trigger the ci flow
try
git rebase masterand push commits, it will re-trigger the ci flow
done it
seems that you need approval to trigger ci flow; I don't have the permission: )
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
This PR was closed because it has been inactive for 3 days since being marked as stale.
@Ceilzcx @mxsm
how about this? continue?
Can we reactivate this PR? @Ziy1-Tan
