rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #7143] Add topic config tools search

Open Ceilzcx opened this issue 2 years ago • 13 comments
trafficstars

Which Issue(s) This PR Fixes

Fixes #7143

Brief Description

How Did You Test This Change?

Ceilzcx avatar Aug 11 '23 07:08 Ceilzcx

@Ceilzcx Hi please link this pr to related issue

done it

Ceilzcx avatar Aug 13 '23 01:08 Ceilzcx

Codecov Report

Merging #7167 (587d22c) into develop (f534501) will decrease coverage by 0.07%. Report is 3 commits behind head on develop. The diff coverage is 30.30%.

@@              Coverage Diff              @@
##             develop    #7167      +/-   ##
=============================================
- Coverage      42.52%   42.45%   -0.07%     
+ Complexity      9357     9350       -7     
=============================================
  Files           1149     1150       +1     
  Lines          82043    82074      +31     
  Branches       10701    10705       +4     
=============================================
- Hits           34889    34847      -42     
- Misses         42792    42863      +71     
- Partials        4362     4364       +2     
Files Changed Coverage Δ
.../apache/rocketmq/tools/command/MQAdminStartup.java 0.00% <0.00%> (ø)
.../tools/command/topic/GetTopicConfigSubCommand.java 30.00% <30.00%> (ø)
...s/command/broker/BrokerConsumeStatsSubCommand.java 40.27% <100.00%> (ø)

... and 19 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 14 '23 02:08 codecov-commenter

you can refer to GetConsumerConfigSubCommand.

Ziy1-Tan avatar Aug 14 '23 05:08 Ziy1-Tan

thank you for you comment,like this? image

Ceilzcx avatar Aug 14 '23 06:08 Ceilzcx

Is there anything else i need to add? @mxsm please review it? thanks

Ceilzcx avatar Aug 17 '23 11:08 Ceilzcx

changes LGTM, but there are test failures, please check out :) 图片

sorry, I'm not understand, I didn't change the code about rocketmq-store module, and I can pass the test in local, i don't know how to fix it

Ceilzcx avatar Aug 23 '23 13:08 Ceilzcx

changes LGTM, but there are test failures, please check out :) 图片

sorry, I'm not understand, I didn't change the code about rocketmq-store module, and I can pass the test in local, i don't know how to fix it

retry?

joeCarf avatar Aug 23 '23 13:08 joeCarf

changes LGTM, but there are test failures, please check out :) 图片

sorry, I'm not understand, I didn't change the code about rocketmq-store module, and I can pass the test in local, i don't know how to fix it

retry?

well, the first when I pr has no failures

Ceilzcx avatar Aug 23 '23 13:08 Ceilzcx

you see re-run the jobs? I don't have permission.

Ceilzcx avatar Aug 23 '23 13:08 Ceilzcx

try git rebase master and push commits, it will re-trigger the ci flow

joeCarf avatar Aug 24 '23 02:08 joeCarf

try git rebase master and push commits, it will re-trigger the ci flow

done it

Ceilzcx avatar Aug 24 '23 03:08 Ceilzcx

seems that you need approval to trigger ci flow; I don't have the permission: )

joeCarf avatar Aug 25 '23 12:08 joeCarf

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Aug 25 '24 00:08 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Aug 29 '24 00:08 github-actions[bot]

@Ceilzcx @mxsm

how about this? continue?

dyrnq avatar Oct 30 '25 00:10 dyrnq

Can we reactivate this PR? @Ziy1-Tan

dyrnq avatar Oct 30 '25 00:10 dyrnq