rocketmq
rocketmq copied to clipboard
[ISSUE #5126]Make all tests pass on Windows
Make sure set the target branch to develop
What is the purpose of the change
Fix https://github.com/apache/rocketmq/issues/5126
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.
- [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
- [x] Run
mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.
Codecov Report
Merging #5127 (1544921) into develop (96f340d) will decrease coverage by
0.00%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## develop #5127 +/- ##
=============================================
- Coverage 43.28% 43.28% -0.01%
- Complexity 7800 7806 +6
=============================================
Files 997 997
Lines 69349 69353 +4
Branches 9168 9168
=============================================
- Hits 30019 30016 -3
- Misses 35553 35573 +20
+ Partials 3777 3764 -13
Impacted Files | Coverage Δ | |
---|---|---|
...he/rocketmq/remoting/protocol/RemotingCommand.java | 68.40% <0.00%> (ø) |
|
.../apache/rocketmq/tools/monitor/MonitorService.java | 27.32% <0.00%> (ø) |
|
...org/apache/rocketmq/store/ha/WaitNotifyObject.java | 80.35% <0.00%> (-5.36%) |
:arrow_down: |
...ketmq/common/protocol/body/ConsumerConnection.java | 95.83% <0.00%> (-4.17%) |
:arrow_down: |
...apache/rocketmq/remoting/netty/ResponseFuture.java | 77.55% <0.00%> (-4.09%) |
:arrow_down: |
...rocketmq/remoting/netty/NettyRemotingAbstract.java | 49.27% <0.00%> (-3.63%) |
:arrow_down: |
.../apache/rocketmq/logging/inner/LoggingBuilder.java | 63.60% <0.00%> (-0.16%) |
:arrow_down: |
...ent/impl/consumer/DefaultLitePullConsumerImpl.java | 69.84% <0.00%> (-0.16%) |
:arrow_down: |
...va/org/apache/rocketmq/namesrv/NamesrvStartup.java | 15.96% <0.00%> (ø) |
|
.../org/apache/rocketmq/proxy/config/ProxyConfig.java | 49.74% <0.00%> (ø) |
|
... and 19 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more