rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #5018]Some responseCode values are duplicated

Open zhangjidi2016 opened this issue 2 years ago • 1 comments

Make sure set the target branch to develop

What is the purpose of the change

#5018

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

zhangjidi2016 avatar Sep 07 '22 09:09 zhangjidi2016

Need to evaluate impacts on existing users.

There is no effect on the previous user, just change the return code value, responseCode does not change

zhangjidi2016 avatar Sep 13 '22 02:09 zhangjidi2016

Please help to review this patch again. @lizhanhui

zhangjidi2016 avatar Oct 11 '22 08:10 zhangjidi2016

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Oct 12 '23 00:10 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Oct 15 '23 00:10 github-actions[bot]