rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #4688]acl module support namespace.

Open sunxi92 opened this issue 2 years ago • 3 comments

#4688

sunxi92 avatar Aug 03 '22 15:08 sunxi92

Codecov Report

Merging #4769 (c6b78bf) into develop (d174404) will decrease coverage by 0.42%. The diff coverage is 20.24%.

@@              Coverage Diff              @@
##             develop    #4769      +/-   ##
=============================================
- Coverage      43.19%   42.77%   -0.43%     
- Complexity      7813     7866      +53     
=============================================
  Files           1001     1016      +15     
  Lines          69640    70817    +1177     
  Branches        9199     9370     +171     
=============================================
+ Hits           30081    30289     +208     
- Misses         35782    36691     +909     
- Partials        3777     3837      +60     
Impacted Files Coverage Δ
...a/org/apache/rocketmq/acl/common/AclConstants.java 0.00% <ø> (ø)
...ocketmq/broker/processor/AdminBrokerProcessor.java 23.07% <0.00%> (-2.07%) :arrow_down:
...g/apache/rocketmq/client/impl/MQClientAPIImpl.java 21.92% <0.00%> (-1.03%) :arrow_down:
...a/org/apache/rocketmq/common/NamespaceAndPerm.java 0.00% <0.00%> (ø)
...java/org/apache/rocketmq/common/OperationType.java 0.00% <0.00%> (ø)
.../org/apache/rocketmq/common/PlainAccessConfig.java 0.00% <0.00%> (ø)
...va/org/apache/rocketmq/common/ResourceAndPerm.java 0.00% <0.00%> (ø)
.../java/org/apache/rocketmq/common/ResourceType.java 0.00% <0.00%> (ø)
...apache/rocketmq/common/protocol/NamespaceUtil.java 48.57% <0.00%> (-6.27%) :arrow_down:
...g/apache/rocketmq/common/protocol/RequestCode.java 0.00% <ø> (ø)
... and 67 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 04 '22 01:08 codecov-commenter

Coverage Status

Coverage increased (+0.09%) to 49.264% when pulling 80332da69dc0e936b1abfeeb1c7a8d7d0f20d92c on sunxi92:acl_namespace into c6b3a66ecf5e6bdeffb01093e5216bb10ee64a59 on apache:develop.

coveralls avatar Aug 04 '22 01:08 coveralls

Coverage Status

Coverage increased (+0.09%) to 49.264% when pulling 80332da69dc0e936b1abfeeb1c7a8d7d0f20d92c on sunxi92:acl_namespace into c6b3a66ecf5e6bdeffb01093e5216bb10ee64a59 on apache:develop.

coveralls avatar Aug 04 '22 01:08 coveralls

a README.md to show how-to-use would be better

francisoliverlee avatar Aug 30 '22 03:08 francisoliverlee

@sunxi92 Pls add detailed design document previously discussed.

caigy avatar Oct 08 '22 01:10 caigy

@sunxi92 Pls add detailed design document previously discussed.

The detailed design document link is https://shimo.im/docs/47kgJM5eE7inm8qV/

sunxi92 avatar Oct 08 '22 12:10 sunxi92

Hi! Our tool BreakBot found that this pull request introduces 9 breaking changes and they appear to impact 9 of your clients. You can find the full BreakBot report in our fork repository: report for PR#4769.

We hope this information is valuable to you, and apologize otherwise. If you're willing to help, we would kindly ask for your help to fill in a 5-minutes survey about the report. Your feedback will help us improve the tool and provide a better experience for users in the future!

lmove avatar Nov 18 '22 10:11 lmove

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Nov 19 '23 00:11 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Nov 23 '23 00:11 github-actions[bot]