rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #4587] rocketmq thread pool add a "bottom-up" scheme to catch exceptions

Open liuzongliang0202 opened this issue 2 years ago • 2 comments

Make sure set the target branch to develop

What is the purpose of the change

rocketmq thread pool add a "bottom-up" scheme to catch exceptions. Use the uncaught exception handler that comes with the thread

Brief changelog

Refer https://github.com/apache/rocketmq/issues/4587

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

liuzongliang0202 avatar Jul 13 '22 09:07 liuzongliang0202

Coverage Status

Coverage decreased (-0.03%) to 47.598% when pulling f47cc70bece5f43a0b11488434c7ce21a01e83e7 on liuzongliang0202:feature-enhance_threadpool into 10326b479af2282310ea0f496f6c08229e4ae126 on apache:develop.

coveralls avatar Jul 13 '22 13:07 coveralls

Codecov Report

Merging #4603 (f47cc70) into develop (493e52b) will decrease coverage by 4.52%. The diff coverage is 50.00%.

@@              Coverage Diff              @@
##             develop    #4603      +/-   ##
=============================================
- Coverage      48.17%   43.64%   -4.53%     
- Complexity      5129     6246    +1117     
=============================================
  Files            649      817     +168     
  Lines          43045    57656   +14611     
  Branches        5630     7873    +2243     
=============================================
+ Hits           20737    25166    +4429     
- Misses         19801    29247    +9446     
- Partials        2507     3243     +736     
Impacted Files Coverage Δ
.../org/apache/rocketmq/common/ThreadFactoryImpl.java 60.00% <50.00%> (-40.00%) :arrow_down:
...main/java/org/apache/rocketmq/store/StoreUtil.java 21.42% <0.00%> (-50.00%) :arrow_down:
...s/command/consumer/ConsumerProgressSubCommand.java 0.00% <0.00%> (-28.86%) :arrow_down:
...va/org/apache/rocketmq/store/PutMessageResult.java 39.13% <0.00%> (-27.54%) :arrow_down:
...che/rocketmq/common/protocol/body/ClusterInfo.java 62.50% <0.00%> (-25.74%) :arrow_down:
...org/apache/rocketmq/broker/out/BrokerOuterAPI.java 21.56% <0.00%> (-24.91%) :arrow_down:
...pache/rocketmq/store/stats/BrokerStatsManager.java 47.83% <0.00%> (-24.04%) :arrow_down:
...ketmq/client/impl/consumer/PullMessageService.java 49.23% <0.00%> (-21.89%) :arrow_down:
...apache/rocketmq/common/message/MessageDecoder.java 61.04% <0.00%> (-19.84%) :arrow_down:
... and 378 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 493e52b...f47cc70. Read the comment docs.

codecov-commenter avatar Jul 14 '22 03:07 codecov-commenter

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Sep 07 '23 00:09 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Sep 10 '23 00:09 github-actions[bot]