rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

Support for ibm J9

Open yanhom1314 opened this issue 3 years ago • 7 comments

Now system metrics are obtained from com.sun.management.OperatingSystemMXBean for HotSpot JVM, but these are in com.ibm.lang.management.OperatingSystemMXBean for Ibm J9, so need to deduce the target source.

yanhom1314 avatar May 09 '22 10:05 yanhom1314

Coverage Status

Coverage increased (+0.05%) to 47.579% when pulling 929268f918ce139a421555b9ca0bc5f023b892f2 on lyh200:feature-ibm-J9 into 225bc42f9597cd9ff38fd01c2d5168c68a7f5cf8 on apache:develop.

coveralls avatar May 09 '22 11:05 coveralls

Codecov Report

Merging #4267 (929268f) into develop (225bc42) will increase coverage by 0.02%. The diff coverage is 43.24%.

@@              Coverage Diff              @@
##             develop    #4267      +/-   ##
=============================================
+ Coverage      43.42%   43.45%   +0.02%     
- Complexity      6213     6215       +2     
=============================================
  Files            817      819       +2     
  Lines          57654    57683      +29     
  Branches        7873     7874       +1     
=============================================
+ Hits           25037    25065      +28     
+ Misses         29384    29370      -14     
- Partials        3233     3248      +15     
Impacted Files Coverage Δ
...ava/org/apache/rocketmq/store/util/MethodUtil.java 0.00% <0.00%> (ø)
...main/java/org/apache/rocketmq/store/StoreUtil.java 15.38% <50.00%> (-6.05%) :arrow_down:
...che/rocketmq/store/OperatingSystemBeanManager.java 52.00% <52.00%> (ø)
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) :arrow_down:
...org/apache/rocketmq/common/stats/StatsItemSet.java 44.77% <0.00%> (-5.98%) :arrow_down:
...apache/rocketmq/remoting/netty/ResponseFuture.java 79.59% <0.00%> (-2.05%) :arrow_down:
...rocketmq/remoting/netty/NettyRemotingAbstract.java 52.32% <0.00%> (-1.44%) :arrow_down:
...mq/client/impl/consumer/RebalanceLitePullImpl.java 69.86% <0.00%> (-1.37%) :arrow_down:
...client/consumer/store/RemoteBrokerOffsetStore.java 67.56% <0.00%> (-0.91%) :arrow_down:
...nt/impl/consumer/ConsumeMessageOrderlyService.java 49.47% <0.00%> (-0.71%) :arrow_down:
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 225bc42...929268f. Read the comment docs.

codecov-commenter avatar May 09 '22 11:05 codecov-commenter

@lyh200 Is there any other modifications for running RocketMQ on IBM J9, like JVM params? Looking forward to your feedback on scenarios where you use RocketMQ on IBM J9.

caigy avatar May 10 '22 05:05 caigy

@caigy Nothing else is found to modify, ibm j9 is also an optional mainstream jvm, so it is also necessary to support it.

yanhom1314 avatar May 10 '22 12:05 yanhom1314

Is it also compatible to OpenJ9?

yes

yanhom1314 avatar May 13 '22 02:05 yanhom1314

Even better if there are test cases

Kvicii avatar May 21 '22 14:05 Kvicii

Even better if there are test cases

done!

yanhom1314 avatar Jun 29 '22 05:06 yanhom1314

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Feb 19 '24 00:02 github-actions[bot]

Can this PR be merged?

yanhom1314 avatar Feb 22 '24 03:02 yanhom1314