rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #3493] DefaultMQPushConsumer#setConsumeThreadMax(int consumeThreadMax) has no effect.

Open XiaoyiPeng opened this issue 3 years ago • 3 comments

Make sure set the target branch to develop

What is the purpose of the change

1.fix(consumer): DefaultMQPushConsumer#setConsumeThreadMax(int consumeThreadMax) has no effect.

2.fix(consumer): Handle RejectedExecutionException that may be encountered when the call ConsumeMessageConcurrentlyService#submitConsumeRequestLater

Brief changelog

1.Replace unlimited size this.consumeRequestQueue = new LinkedBlockingQueue<Runnable>() with bounded queues when creating ConsumeMessageConcurrentlyService#consumeExecutor, in order to make DefaultMQPushConsumer#setConsumeThreadMax(int consumeThreadMax) to work. 2. consumeExecutor.submit(consumeRequest) may throw an RejectedExecutionException in below code:

private void submitConsumeRequestLater(final ConsumeRequest consumeRequest) {

        this.scheduledExecutorService.schedule(new Runnable() {

            @Override
            public void run() {
                ConsumeMessageConcurrentlyService.this.consumeExecutor.submit(consumeRequest);
            }
        }, 5000, TimeUnit.MILLISECONDS);
} 

but the program does not handle it.

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

XiaoyiPeng avatar Nov 15 '21 13:11 XiaoyiPeng

Coverage Status

Coverage decreased (-0.02%) to 55.075% when pulling 2957d75d390b8e614b73ac2946b6d832ebcdc7c5 on XiaoyiPeng:push_consumer into 4b8b307901da19a1e562c883adc1bdaf8e111cfb on apache:develop.

coveralls avatar Nov 15 '21 14:11 coveralls

Can you create a corresponding issue for this PR?

Git-Yang avatar Nov 16 '21 03:11 Git-Yang

Can you create a corresponding issue for this PR?

OK, thanks for reminding me, please see: #3493

XiaoyiPeng avatar Nov 16 '21 05:11 XiaoyiPeng

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Jul 19 '23 00:07 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Jul 24 '23 00:07 github-actions[bot]