rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #3492] DefaultMQPushConsumerImpl#adjustThreadPool() has no effect.

Open XiaoyiPeng opened this issue 3 years ago • 8 comments

Make sure set the target branch to develop

What is the purpose of the change

for issue #3492

Brief changelog

XX

Verifying this change

XXXX

XiaoyiPeng avatar Nov 13 '21 09:11 XiaoyiPeng

Coverage Status

Coverage increased (+0.03%) to 55.129% when pulling d5942160569831d218bccc65972959aadd7905f5 on XiaoyiPeng:develop into 4b8b307901da19a1e562c883adc1bdaf8e111cfb on apache:develop.

coveralls avatar Nov 13 '21 10:11 coveralls

Codecov Report

Merging #3483 (d594216) into develop (4b8b307) will decrease coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3483      +/-   ##
=============================================
- Coverage      48.80%   48.79%   -0.01%     
  Complexity      4652     4652              
=============================================
  Files            555      555              
  Lines          36724    36732       +8     
  Branches        4839     4839              
=============================================
+ Hits           17924    17925       +1     
- Misses         16553    16558       +5     
- Partials        2247     2249       +2     
Impacted Files Coverage Δ
...pl/consumer/ConsumeMessageConcurrentlyService.java 46.66% <0.00%> (-0.91%) :arrow_down:
...nt/impl/consumer/ConsumeMessageOrderlyService.java 38.43% <0.00%> (-0.56%) :arrow_down:
...ain/java/org/apache/rocketmq/test/util/MQWait.java 43.24% <0.00%> (-10.82%) :arrow_down:
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 78.21% <0.00%> (-1.49%) :arrow_down:
...a/org/apache/rocketmq/store/StoreStatsService.java 30.16% <0.00%> (-0.66%) :arrow_down:
...e/rocketmq/client/impl/consumer/RebalanceImpl.java 40.23% <0.00%> (-0.40%) :arrow_down:
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (ø)
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.31% <0.00%> (+0.12%) :arrow_up:
.../apache/rocketmq/logging/inner/LoggingBuilder.java 63.92% <0.00%> (+0.31%) :arrow_up:
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.28% <0.00%> (+0.33%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b8b307...d594216. Read the comment docs.

codecov-commenter avatar Nov 13 '21 10:11 codecov-commenter

@dongeforever Take a look when you have time please, thank you very much.

XiaoyiPeng avatar Nov 15 '21 08:11 XiaoyiPeng

Can you create an issue for this PR?

Git-Yang avatar Nov 16 '21 03:11 Git-Yang

Can you create an issue for this PR?

OK, thanks for reminding me, please see: https://github.com/apache/rocketmq/issues/3492

XiaoyiPeng avatar Nov 16 '21 03:11 XiaoyiPeng

nice, LGTM!

guyinyou avatar Nov 29 '21 12:11 guyinyou

nice, LGTM!

Thanks for your review, can you approve these changes?

XiaoyiPeng avatar Nov 30 '21 07:11 XiaoyiPeng

LGTM

tianliuliu avatar Mar 10 '22 06:03 tianliuliu

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Jul 19 '23 00:07 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Jul 24 '23 00:07 github-actions[bot]

why this commit didn't be merged?

Yelijah avatar Feb 22 '24 08:02 Yelijah