rocketmq
rocketmq copied to clipboard
Safely delete parameters and variables that have never been used
Make sure set the target branch to develop
What is the purpose of the change
- Streamline code and increase readability
Brief changelog
- Safely delete parameters and variables that have never been used
- Related change files:DefaultRequestProcessor && KVConfigManager
Verifying this change
- Verified
Coverage increased (+0.1%) to 54.212% when pulling e52fc184773b63d343cfbbfc1342eb5dd1d75d72 on pirateskipper:r-issues into 44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop.
Codecov Report
Merging #3248 (e52fc18) into develop (5203d52) will increase coverage by
1.79%
. The diff coverage is31.25%
.
@@ Coverage Diff @@
## develop #3248 +/- ##
=============================================
+ Coverage 47.93% 49.72% +1.79%
- Complexity 4564 5012 +448
=============================================
Files 552 552
Lines 36628 40169 +3541
Branches 4844 5813 +969
=============================================
+ Hits 17558 19975 +2417
- Misses 16850 17815 +965
- Partials 2220 2379 +159
Impacted Files | Coverage Δ | |
---|---|---|
...tmq/namesrv/processor/DefaultRequestProcessor.java | 35.93% <26.66%> (ø) |
|
...che/rocketmq/namesrv/kvconfig/KVConfigManager.java | 59.18% <100.00%> (ø) |
|
.../rocketmq/broker/pagecache/OneMessageTransfer.java | 22.58% <0.00%> (-10.76%) |
:arrow_down: |
...a/org/apache/rocketmq/logging/inner/SysLogger.java | 28.57% <0.00%> (-5.72%) |
:arrow_down: |
...ketmq/client/impl/consumer/PullMessageService.java | 75.55% <0.00%> (-4.45%) |
:arrow_down: |
...java/org/apache/rocketmq/logging/inner/Logger.java | 52.15% <0.00%> (-3.83%) |
:arrow_down: |
...ava/org/apache/rocketmq/test/util/VerifyUtils.java | 46.26% <0.00%> (-2.99%) |
:arrow_down: |
...rocketmq/broker/pagecache/ManyMessageTransfer.java | 43.58% <0.00%> (-2.57%) |
:arrow_down: |
...ava/org/apache/rocketmq/filter/util/BitsArray.java | 59.82% <0.00%> (-2.57%) |
:arrow_down: |
...a/org/apache/rocketmq/filter/util/BloomFilter.java | 59.13% <0.00%> (-2.16%) |
:arrow_down: |
... and 52 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5203d52...e52fc18. Read the comment docs.
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.
This PR was closed because it has been inactive for 3 days since being marked as stale.