rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

use the StringBuilder another method can reduce impact on array copy performance

Open gylang opened this issue 3 years ago • 4 comments

…performance

use the StringBuilder another method can reduce impact on array copy performance

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

gylang avatar Aug 09 '21 23:08 gylang

Coverage Status

Coverage increased (+0.1%) to 54.192% when pulling 3eee57dba31ba7ebd317bfa4d508fa3717005b9f on gylang:develop into 44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop.

coveralls avatar Aug 10 '21 00:08 coveralls

Codecov Report

Merging #3239 (3eee57d) into develop (44bdeed) will decrease coverage by 3.17%. The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3239      +/-   ##
=============================================
- Coverage      48.08%   44.90%   -3.18%     
+ Complexity      4575     3498    -1077     
=============================================
  Files            552      470      -82     
  Lines          36521    28998    -7523     
  Branches        4818     3762    -1056     
=============================================
- Hits           17561    13022    -4539     
+ Misses         16747    14257    -2490     
+ Partials        2213     1719     -494     
Impacted Files Coverage Δ
...rg/apache/rocketmq/logging/InnerLoggerFactory.java 31.62% <50.00%> (ø)
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) :arrow_down:
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) :arrow_down:
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) :arrow_down:
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) :arrow_down:
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-2.99%) :arrow_down:
...a/org/apache/rocketmq/filter/util/BloomFilter.java 59.13% <0.00%> (-2.16%) :arrow_down:
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) :arrow_down:
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 77.72% <0.00%> (-1.49%) :arrow_down:
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.52% <0.00%> (-1.48%) :arrow_down:
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44bdeed...3eee57d. Read the comment docs.

codecov-commenter avatar Aug 10 '21 00:08 codecov-commenter

Please submit an issue first, this pr is associated with this issue

odbozhou avatar Aug 10 '21 05:08 odbozhou

the develop branch has force-pushed. please rebase this pr.

git rebase develop

areyouok avatar Sep 06 '21 12:09 areyouok

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Jul 20 '23 00:07 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Jul 23 '23 00:07 github-actions[bot]