rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #3231]add topic expire time policy

Open makabakaboom opened this issue 3 years ago • 3 comments

Make sure set the target branch to develop

What is the purpose of the change

#3231

Brief changelog

#3231

Verifying this change

#3231

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

makabakaboom avatar Aug 07 '21 14:08 makabakaboom

Coverage Status

Coverage increased (+0.07%) to 54.158% when pulling 9c24c3ae7b8aa44c2b23416a17057739fce41543 on makabakaboom:topic-expire into 44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop.

coveralls avatar Aug 07 '21 14:08 coveralls

Codecov Report

Merging #3232 (9c24c3a) into develop (44bdeed) will decrease coverage by 0.01%. The diff coverage is 35.48%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3232      +/-   ##
=============================================
- Coverage      47.95%   47.93%   -0.02%     
- Complexity      4565     4568       +3     
=============================================
  Files            552      553       +1     
  Lines          36521    36569      +48     
  Branches        4818     4822       +4     
=============================================
+ Hits           17514    17531      +17     
- Misses         16795    16815      +20     
- Partials        2212     2223      +11     
Impacted Files Coverage Δ
...mmon/protocol/header/CreateTopicRequestHeader.java 0.00% <0.00%> (ø)
...n/java/org/apache/rocketmq/store/MessageStore.java 0.00% <ø> (ø)
...apache/rocketmq/store/config/TopicStorePolicy.java 0.00% <0.00%> (ø)
...n/java/org/apache/rocketmq/common/TopicConfig.java 39.79% <10.00%> (-3.39%) :arrow_down:
...n/java/org/apache/rocketmq/store/ConsumeQueue.java 63.75% <25.00%> (-0.50%) :arrow_down:
...ocketmq/broker/processor/AdminBrokerProcessor.java 8.08% <33.33%> (+0.16%) :arrow_up:
...org/apache/rocketmq/store/DefaultMessageStore.java 55.47% <50.00%> (-0.07%) :arrow_down:
...ache/rocketmq/broker/topic/TopicConfigManager.java 59.46% <80.00%> (+0.39%) :arrow_up:
...a/org/apache/rocketmq/broker/BrokerController.java 45.00% <100.00%> (+0.09%) :arrow_up:
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) :arrow_down:
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44bdeed...9c24c3a. Read the comment docs.

codecov-commenter avatar Aug 07 '21 14:08 codecov-commenter

Please resolve the branch conflict

odbozhou avatar Jan 19 '22 06:01 odbozhou

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Jul 20 '23 00:07 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Jul 23 '23 00:07 github-actions[bot]