rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #3229] check running status when schedule new DeliveryMessageTimerTask.

Open lifepuzzlefun opened this issue 3 years ago • 4 comments

when ScheduleMessageService stoped. the timer canceled. and new schedule task will cause exception. then show "ScheduleMessageService, messageTimeup execute error, drop it. msgExt" in log.

lifepuzzlefun avatar Aug 07 '21 13:08 lifepuzzlefun

Coverage Status

Coverage increased (+0.1%) to 54.231% when pulling 3dd37caf40e96420a8c695c5f82716d1231992e2 on WJL3333:fix_schedule_task_drop_message into 44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop.

coveralls avatar Aug 07 '21 13:08 coveralls

Codecov Report

Merging #3230 (3dd37ca) into develop (44bdeed) will increase coverage by 0.05%. The diff coverage is 55.55%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3230      +/-   ##
=============================================
+ Coverage      47.95%   48.00%   +0.05%     
- Complexity      4565     4568       +3     
=============================================
  Files            552      552              
  Lines          36521    36525       +4     
  Branches        4818     4819       +1     
=============================================
+ Hits           17514    17535      +21     
+ Misses         16795    16768      -27     
- Partials        2212     2222      +10     
Impacted Files Coverage Δ
...ocketmq/store/schedule/ScheduleMessageService.java 73.76% <55.55%> (-0.49%) :arrow_down:
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.36%) :arrow_down:
...a/org/apache/rocketmq/filter/util/BloomFilter.java 59.13% <0.00%> (-2.16%) :arrow_down:
...he/rocketmq/client/trace/AsyncTraceDispatcher.java 77.72% <0.00%> (-1.49%) :arrow_down:
...ketmq/common/protocol/body/RegisterBrokerBody.java 83.69% <0.00%> (-1.09%) :arrow_down:
...n/java/org/apache/rocketmq/store/ha/HAService.java 71.28% <0.00%> (-0.67%) :arrow_down:
...he/rocketmq/remoting/protocol/RemotingCommand.java 78.22% <0.00%> (-0.41%) :arrow_down:
...mq/client/impl/producer/DefaultMQProducerImpl.java 44.86% <0.00%> (-0.37%) :arrow_down:
...main/java/org/apache/rocketmq/store/CommitLog.java 73.53% <0.00%> (-0.12%) :arrow_down:
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44bdeed...3dd37ca. Read the comment docs.

codecov-commenter avatar Aug 07 '21 13:08 codecov-commenter

+1

ltamber avatar Aug 09 '21 02:08 ltamber

Can you resolve the conflict?

Git-Yang avatar Nov 26 '21 04:11 Git-Yang

file conflicted now, it is better to resolve it first.

ShannonDing avatar Aug 10 '22 11:08 ShannonDing