rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #3227]add topic message queue count/size statistics and add tools to query it

Open makabakaboom opened this issue 3 years ago • 2 comments

Make sure set the target branch to develop

What is the purpose of the change

#3227

Brief changelog

#3227

Verifying this change

#3227

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

makabakaboom avatar Aug 07 '21 08:08 makabakaboom

Coverage Status

Coverage increased (+0.08%) to 54.175% when pulling 680822b96082c446a053ca7e49936b3e70b07d7a on makabakaboom:consumeQueue-statistics into 44bdeedad2d0e28717f5012d375d12af76305bb5 on apache:develop.

coveralls avatar Aug 07 '21 08:08 coveralls

Codecov Report

Merging #3228 (680822b) into develop (5203d52) will increase coverage by 0.52%. The diff coverage is 24.19%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3228      +/-   ##
=============================================
+ Coverage      47.93%   48.46%   +0.52%     
+ Complexity      4564     3196    -1368     
=============================================
  Files            552      419     -133     
  Lines          36628    26378   -10250     
  Branches        4844     3495    -1349     
=============================================
- Hits           17558    12783    -4775     
+ Misses         16850    11943    -4907     
+ Partials        2220     1652     -568     
Impacted Files Coverage Δ
...etmq/broker/plugin/AbstractPluginMessageStore.java 0.00% <0.00%> (ø)
...ocketmq/broker/processor/AdminBrokerProcessor.java 7.62% <0.00%> (-0.34%) :arrow_down:
...he/rocketmq/common/admin/TopicQueueStatistics.java 0.00% <0.00%> (ø)
...g/apache/rocketmq/common/protocol/RequestCode.java 0.00% <ø> (ø)
...n/java/org/apache/rocketmq/store/MessageStore.java 0.00% <ø> (ø)
...org/apache/rocketmq/store/DefaultMessageStore.java 55.62% <50.00%> (-0.09%) :arrow_down:
.../apache/rocketmq/common/admin/TopicStatsTable.java 100.00% <100.00%> (ø)
...cketmq/remoting/protocol/RemotingSerializable.java 68.42% <100.00%> (+5.92%) :arrow_up:
...n/java/org/apache/rocketmq/store/ConsumeQueue.java 65.43% <100.00%> (+1.19%) :arrow_up:
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-14.70%) :arrow_down:
... and 174 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5203d52...680822b. Read the comment docs.

codecov-commenter avatar Aug 07 '21 08:08 codecov-commenter

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Jul 20 '23 00:07 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Jul 23 '23 00:07 github-actions[bot]