rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE#2949]delete the method of correctDeliverTimestamp in DeliverDelayedMessageTimerTask

Open sunxi92 opened this issue 3 years ago • 2 comments

It's a redundant operation to correct deliverTimestamp when sending scheduled message, so I delete the method of correctDeliverTimestamp, and the value of countdown is the time difference between the current time and deliverTimestamp(tagsCode)

#2949

sunxi92 avatar May 31 '21 02:05 sunxi92

Coverage Status

Coverage decreased (-0.04%) to 51.779% when pulling b6a74067a6b50bf0ddf08f31d6ae7dc23b97e3ca on sunxi92:schedulemessage into aaa92a2e53d773c7f1d9e9f25e41709f6948fa83 on apache:master.

coveralls avatar May 31 '21 02:05 coveralls

Codecov Report

Merging #2959 (b6a7406) into master (3ae2517) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2959      +/-   ##
============================================
- Coverage     45.98%   45.97%   -0.01%     
+ Complexity     4320     4318       -2     
============================================
  Files           547      547              
  Lines         36236    36235       -1     
  Branches       4808     4808              
============================================
- Hits          16663    16659       -4     
+ Misses        17490    17489       -1     
- Partials       2083     2087       +4     
Impacted Files Coverage Δ
...ocketmq/store/schedule/ScheduleMessageService.java 72.25% <100.00%> (-1.71%) :arrow_down:
...ketmq/client/impl/consumer/PullMessageService.java 71.11% <0.00%> (-8.89%) :arrow_down:
...sumer/rebalance/AllocateMessageQueueAveragely.java 56.52% <0.00%> (-4.35%) :arrow_down:
...ketmq/common/protocol/body/ConsumerConnection.java 95.83% <0.00%> (-4.17%) :arrow_down:
...mq/client/impl/consumer/RebalanceLitePullImpl.java 50.84% <0.00%> (-3.39%) :arrow_down:
...ava/org/apache/rocketmq/test/util/VerifyUtils.java 46.26% <0.00%> (-2.99%) :arrow_down:
...client/consumer/store/RemoteBrokerOffsetStore.java 67.56% <0.00%> (-1.81%) :arrow_down:
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) :arrow_down:
...etmq/client/latency/LatencyFaultToleranceImpl.java 50.00% <0.00%> (-1.29%) :arrow_down:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ae2517...b6a7406. Read the comment docs.

codecov-commenter avatar May 31 '21 02:05 codecov-commenter

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar Feb 22 '24 00:02 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar Feb 25 '24 00:02 github-actions[bot]