rocketmq icon indicating copy to clipboard operation
rocketmq copied to clipboard

[ISSUE #2148] Optimize hash ‘SelectMessageQueueByHash' for Producer in order to select queue more balanced

Open xiaobing395845388 opened this issue 5 years ago • 3 comments

What is the purpose of the change

feature #2148

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

xiaobing395845388 avatar Jul 10 '20 09:07 xiaobing395845388

Coverage Status

Coverage increased (+0.07%) to 51.295% when pulling 66420afe9f72455212f1e4869242bc5a09fdf713 on xiaobing395845388:master into fac30c3596d5577cd80a52af9ad89a0839016137 on apache:develop.

coveralls avatar Jul 10 '20 10:07 coveralls

Can this pr be merged?

xiaobing395845388 avatar Apr 26 '22 01:04 xiaobing395845388

This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR.

github-actions[bot] avatar May 24 '24 00:05 github-actions[bot]

This PR was closed because it has been inactive for 3 days since being marked as stale.

github-actions[bot] avatar May 28 '24 00:05 github-actions[bot]