ratis
ratis copied to clipboard
RATIS-1550. Refactor stream client reply queue
What changes were proposed in this pull request?
This PR does two things
- I found that a timeout occurred on the client side, In fact, the server is fine and there are no errors or timeouts, I opened the debug log and found that the client Reply queue had mismatched responses.
- Delete the replyQueueGracePeriod logic, the Reply queue is cleared, triggered when a close stream is received.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1550
This version has been running in my environment for a long time without a client Timeout exception Hi, @szetszwo Can you look at this PR
@guohao-rosicky , is this a bug fix? Or just a refactoring?
@guohao-rosicky , is this a bug fix? Or just a refactoring?
hi, @szetszwo I changed the description of this PR
- Bug fix timeout exception.
- Refactor the code to optimize the logic of replyQueueGracePeriod.
- Bug fix timeout exception.
- Refactor the code to optimize the logic of replyQueueGracePeriod.
Could you separate these changes into two JIRAs?
@guohao-rosicky , could you resolve the conflicts?
@guohao-rosicky , could you resolve the conflicts?
sure.
Thanks @szetszwo for the review, pr already rebase and ci is passed. see: https://github.com/guohao-rosicky/ratis/actions/runs/5710518500
Thanks @szetszwo for the review, ci is passed please see: https://github.com/guohao-rosicky/ratis/actions/runs/5734705067