ratis icon indicating copy to clipboard operation
ratis copied to clipboard

RATIS-1550. Refactor stream client reply queue

Open guohao-rosicky opened this issue 2 years ago • 4 comments

What changes were proposed in this pull request?

This PR does two things

  1. I found that a timeout occurred on the client side, In fact, the server is fine and there are no errors or timeouts, I opened the debug log and found that the client Reply queue had mismatched responses.
  2. Delete the replyQueueGracePeriod logic, the Reply queue is cleared, triggered when a close stream is received.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-1550

guohao-rosicky avatar Sep 09 '22 06:09 guohao-rosicky

This version has been running in my environment for a long time without a client Timeout exception Hi, @szetszwo Can you look at this PR

guohao-rosicky avatar Sep 09 '22 07:09 guohao-rosicky

@guohao-rosicky , is this a bug fix? Or just a refactoring?

szetszwo avatar Sep 13 '22 09:09 szetszwo

@guohao-rosicky , is this a bug fix? Or just a refactoring?

hi, @szetszwo I changed the description of this PR

  1. Bug fix timeout exception.
  2. Refactor the code to optimize the logic of replyQueueGracePeriod.

guohao-rosicky avatar Sep 13 '22 09:09 guohao-rosicky

  1. Bug fix timeout exception.
  2. Refactor the code to optimize the logic of replyQueueGracePeriod.

Could you separate these changes into two JIRAs?

szetszwo avatar Sep 13 '22 10:09 szetszwo

@guohao-rosicky , could you resolve the conflicts?

szetszwo avatar Jul 18 '23 23:07 szetszwo

@guohao-rosicky , could you resolve the conflicts?

sure.

guohao-rosicky avatar Jul 24 '23 08:07 guohao-rosicky

Thanks @szetszwo for the review, pr already rebase and ci is passed. see: https://github.com/guohao-rosicky/ratis/actions/runs/5710518500

guohao-rosicky avatar Jul 31 '23 06:07 guohao-rosicky

Thanks @szetszwo for the review, ci is passed please see: https://github.com/guohao-rosicky/ratis/actions/runs/5734705067

guohao-rosicky avatar Aug 02 '23 06:08 guohao-rosicky