ratis icon indicating copy to clipboard operation
ratis copied to clipboard

Published 20 hours ago • verified publisher icon apache

RATIS-1530. Cleanup NettyClientStreamRpc#replies empty queue optimize

Open guohao-rosicky opened this issue 2 years ago • 2 comments

What changes were proposed in this pull request?

Cleanup NettyClientStreamRpc#replies empty queue optimize

I can use the Netty scheduleAtFixedRate periodic scheduling cleanup empty queue

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-1530

guohao-rosicky avatar Mar 10 '22 06:03 guohao-rosicky

What do you think of this feature? @szetszwo

guohao-rosicky avatar Mar 10 '22 06:03 guohao-rosicky

@guohao-rosicky , it seems that we won't get much benefit when optimizing the case when the queue is empty (i.e. when there are no requests.)

Also, running tasks in the background actually may make the worst case (when there are many requests) more worst. What do you think?

szetszwo avatar Mar 10 '22 14:03 szetszwo

After RATIS-1550, this is no longer a problem. Closing this.

szetszwo avatar Apr 10 '24 21:04 szetszwo