ratis icon indicating copy to clipboard operation
ratis copied to clipboard
verified publisher icon apache

RATIS-2176. Update doc for raft.server.log.appender.wait-time.min.

Open jojochuang opened this issue 1 year ago • 2 comments

What changes were proposed in this pull request?

RATIS-1886 updated the default value of raft.server.log.appender.wait-time.min but didn't update the doc.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/RATIS-2176

How was this patch tested?

User doc change. No production code change.

jojochuang avatar Nov 22 '24 23:11 jojochuang

The failed test is unrelated. It was reported and supposedly fixed by https://issues.apache.org/jira/browse/RATIS-2098

jojochuang avatar Nov 23 '24 07:11 jojochuang

Actually, just updating the doc is not sufficient.

GrpcLogAppender.StreamObservers.onNext() calls sleep for waitForReady, but internally it uses Thread.sleep() so it is never going to be less than one millisecond.

I'm looking at an Ozone cluster where follower DataNode completes the append follower_append_entry_latency just 0.66ms, but the leader's log_appender_latency is 1.36ms. Clearly, the one millisecond sleep granulaity is the problem for the append latency.

jojochuang avatar Dec 03 '24 01:12 jojochuang