ranger icon indicating copy to clipboard operation
ranger copied to clipboard
verified publisher icon apache

RANGER-5217: revert mandatory distinct clause as getPolicy request may fail for oracle

Open pradeepagrawal8184 opened this issue 7 months ago • 3 comments

What changes were proposed in this pull request?

getPolicy request may fail as the distinct query clause is not valid for oracle. This PR reverts the changes done by RANGER-4410 commit https://github.com/apache/ranger/commit/7528f5d1385bbbcba44bb22157a7e12df38f0570

How was this patch tested?

After the build tried the get policy call which was failing earlier.

pradeepagrawal8184 avatar May 30 '25 13:05 pradeepagrawal8184

@pradeepagrawal8184 - wouldn't this revert cause regression in GDS search API (enhancements in RANGER-4410)?

mneethiraj avatar May 30 '25 17:05 mneethiraj

@pradeepagrawal8184 - wouldn't this revert cause regression in GDS search API (enhancements in RANGER-4410)?

  1. This PR is reverting the change done via RANGER-4410 which regressed the getPolicy download call in oracle env.
  2. From RANGER-4410 changes, i am unable to figure out why distinct was needed. i can try to re-create the referred sql statement which shall work across db flavors after understanding the idea behind the RANGER-4410 implementation.
  3. Also in SearchCriteria file there is reference to isDistinct which is false always.

pradeepagrawal8184 avatar Jun 02 '25 06:06 pradeepagrawal8184

@pradeepagrawal8184 and @mneethiraj disabling distinct is expected to break following APIs

  • /service/gds/dataset/summary?dataShareNamePartial=Test_datashare
  • /service/gds/datashare/summary?dataShareNamePartial=Test_datashare

kishorgollapalliwar avatar Jun 03 '25 14:06 kishorgollapalliwar