ranger icon indicating copy to clipboard operation
ranger copied to clipboard

RANGER-4916: Before redirect check and remove index.html

Open prabhjyotsingh opened this issue 1 year ago • 1 comments

What changes were proposed in this pull request?

RANGER-4916: Before redirect check and remove index.html

Sometimes when the session gets timed-out the page does not redirect to the "login.jsp" page, it's instead gets stuck on "/index.htmllogin.jsp#/policymanager/resource" Screenshot 2024-08-22 at 8 23 45 AM

How was this patch tested?

This was tested manually. Steps to repro:

  • Login into ranger UI
  • Either wait for the session to time out or manually delete "RANGERADMINSESSIONID" cookie, the page should get redirected to the right URL

prabhjyotsingh avatar Aug 22 '24 12:08 prabhjyotsingh

@RakeshGuptaDev sure, I've made those changes.

prabhjyotsingh avatar Aug 28 '24 17:08 prabhjyotsingh

@kumaab @rameeshm @kokosing Can you please help review this PR?

prabhjyotsingh avatar Sep 05 '24 12:09 prabhjyotsingh

@dhavaljrajpara can you please help review?

prabhjyotsingh avatar Sep 11 '24 15:09 prabhjyotsingh

Hi team, I'm just checking in on the status of my pull request. Would you be able to review it soon? Would appreciate any feedback or suggestions on this PR. Thanks!

CC: @fateh288 @mneethiraj @mehulbparikh @pradeepagrawal8184 @spolavarpau1 @vperiasamy can you please help review?

prabhjyotsingh avatar Sep 17 '24 12:09 prabhjyotsingh

@prabhjyotsingh, tested your changes on a cluster, but it is not working. The redirect url location is not getting created correctly. Screenshot from 2024-09-18 14-42-32

We already have a jira reported - RANGER-4213 which is handling this redirect issue and its status code.

Thank you for spending time on providing the fix. We are going with the fix provided in jira - RANGER-4213

fimugdha avatar Sep 18 '24 10:09 fimugdha

cc @mneethiraj

fimugdha avatar Sep 18 '24 10:09 fimugdha

Thank you for the review @fimugdha. I can confirm https://reviews.apache.org/r/74772/ works as well.

prabhjyotsingh avatar Sep 18 '24 14:09 prabhjyotsingh