pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][broker] Fix various error-prone detected errors mainly in logging and String.format parameters

Open lhotari opened this issue 1 month ago • 1 comments

Motivation

error-prone detected some logging and String.format parameter errors in pulsar-broker module.

Modifications

  • fix the issues

Documentation

  • [ ] doc
  • [ ] doc-required
  • [x] doc-not-needed
  • [ ] doc-complete

lhotari avatar Dec 10 '25 11:12 lhotari

Codecov Report

:x: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 74.37%. Comparing base (b3c5148) to head (365dca6). :warning: Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...roker/service/PulsarMetadataEventSynchronizer.java 0.00% 3 Missing :warning:
...ategy/DefaultNamespaceBundleSplitStrategyImpl.java 0.00% 1 Missing :warning:
...er/service/persistent/GeoPersistentReplicator.java 0.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #25059      +/-   ##
============================================
+ Coverage     74.33%   74.37%   +0.03%     
+ Complexity    34105    33609     -496     
============================================
  Files          1921     1921              
  Lines        150387   150387              
  Branches      17470    17470              
============================================
+ Hits         111797   111847      +50     
+ Misses        29664    29618      -46     
+ Partials       8926     8922       -4     
Flag Coverage Δ
inttests 26.36% <10.00%> (-0.03%) :arrow_down:
systests 22.87% <10.00%> (-0.01%) :arrow_down:
unittests 73.90% <50.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 90.88% <100.00%> (ø)
...adbalance/extensions/scheduler/SplitScheduler.java 87.50% <100.00%> (ø)
...sar/broker/service/persistent/PersistentTopic.java 79.84% <100.00%> (+0.07%) :arrow_up:
...ker/stats/prometheus/NamespaceStatsAggregator.java 94.33% <100.00%> (ø)
...ategy/DefaultNamespaceBundleSplitStrategyImpl.java 77.27% <0.00%> (ø)
...er/service/persistent/GeoPersistentReplicator.java 71.65% <0.00%> (ø)
...roker/service/PulsarMetadataEventSynchronizer.java 45.61% <0.00%> (ø)

... and 70 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Dec 10 '25 14:12 codecov-commenter