pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[Doc] Incorrect description of UniformLoadShedder in pulsar site.

Open thetumbled opened this issue 1 year ago • 1 comments

Search before asking

  • [X] I searched in the issues and found nothing similar.

What issue do you find in Pulsar docs?

There are some errors in the description of the UniformLoadShedder. https://pulsar.apache.org/docs/next/administration-load-balance/#uniformloadshedder

image

We judge whether MsgRateThresholdExceeded by (Max-Min)/Min > Threshold as the graph show. But judge whether MsgThroughputThresholdExceeded by Max/Min > Threshold.

        double msgRateDifferencePercentage = ((maxMsgRate.getValue() - minMsgRate.getValue()) * 100)
                / (minMsgRate.getValue());
        double msgThroughputDifferenceRate = maxThroughput.getValue() / minThroughput.getValue();

        // if the threshold matches then find out how much load needs to be unloaded by considering number of msgRate
        // and throughput.
        boolean isMsgRateThresholdExceeded = conf.getLoadBalancerMsgRateDifferenceShedderThreshold() > 0
                && msgRateDifferencePercentage > conf.getLoadBalancerMsgRateDifferenceShedderThreshold();
        boolean isMsgThroughputThresholdExceeded = conf
                .getLoadBalancerMsgThroughputMultiplierDifferenceShedderThreshold() > 0
                && msgThroughputDifferenceRate > conf
                .getLoadBalancerMsgThroughputMultiplierDifferenceShedderThreshold();

What is your suggestion?

Correct the description of UniformLoadShedder.

Any reference?

No response

Are you willing to submit a PR?

  • [ ] I'm willing to submit a PR!

thetumbled avatar Jun 05 '24 02:06 thetumbled

PTAL, thanks. @Demogorgon314 @lhotari @heesung-sn I am not good at plotting graph, may be we need the author to fix this.

thetumbled avatar Jun 05 '24 03:06 thetumbled