pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][broker] Skip reading entries from closed cursor.

Open dao-jun opened this issue 1 year ago • 1 comments

Fixes https://github.com/apache/pulsar/issues/22748

Motivation

see: https://github.com/apache/pulsar/issues/22748#issuecomment-2121171595

Modifications

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The threading model
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] The metrics
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [ ] doc-required
  • [x] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository:

dao-jun avatar May 21 '24 10:05 dao-jun

Is it possible to add a test for it?

mattisonchao avatar Jun 01 '24 17:06 mattisonchao

@Technoboy- @mattisonchao Test completed, PTAL

dao-jun avatar Aug 16 '24 20:08 dao-jun