pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][ml]: subscription props could be lost in case of missing ledger during recovery

Open nicoloboschi opened this issue 1 year ago • 1 comments

Motivation

During the recovery of the cursor, if the stored position points to a non existent ledger, the cursor is rewinded to the oldest position. In this case the subscription properties won't be stored in the managedcursor info on the metadata store

Modifications

  • Pass the cursorProperties instead of an empty map during recovery

Verifying this change

  • [x] Make sure that the change passes the CI checks.

  • [x] doc-not-needed

nicoloboschi avatar May 02 '24 20:05 nicoloboschi

@nicoloboschi Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

github-actions[bot] avatar May 02 '24 20:05 github-actions[bot]