pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][broker] Taking message deduplication snapshot when closing topic

Open mattisonchao opened this issue 1 year ago • 2 comments

Motivation

The current implementation of message deduplication snapshot-taking may leave a very huge lag when traffic is high. if load balancer or someone tries to unload/load this topic the loading process may taking very long time.

Modifications

  • Make message deduplication snapshot method return a future.
  • Support force taking snapshot without interval condition check.
  • Taking the snapshot when closing the topic

Verifying this change

  • [x] Make sure that the change passes the CI checks.

Documentation

  • [ ] doc
  • [ ] doc-required
  • [x] doc-not-needed
  • [ ] doc-complete

mattisonchao avatar Apr 13 '24 05:04 mattisonchao

@mattisonchao Please fix the ci check failures

dao-jun avatar Apr 15 '24 09:04 dao-jun

sorry, this PR still need some changes. @dao-jun

mattisonchao avatar Apr 15 '24 10:04 mattisonchao